Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior when using 2 UI dependent modsuit modules. #27828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyunkyunkyun
Copy link
Contributor

@kyunkyunkyun kyunkyunkyun commented Jan 4, 2025

What Does This PR Do

Makes UI based modsuit modules act like on TG.
Allows to use crew monitor module, gps module with modsuit state off.
Doesn't anymore spawns a crew monitor/gps in your hand with nodrop flag, instead just opens a UI on module use.
Turns off mod's GPS by default, so you are not going to see "Syndiecake" or "DK Excavator" on your GPS roundstart because of the mods that are spawned in the ruins.

Why It's Good For The Game

There was no point of using them. Most of the time you use GPS or a crew monitor - you have them in pockets, belt or chest slot, so their UI stands open and you can track the data to get the most recent info. Having them in your hands was ridiculous.

With this PR they become useful - you trade 1 pocket or similar slot for 1 modsuit complexity.

Blueshield doesn't have to turn on his modsuit in order to track the heads' vital sensors. Same for miners/explorers.

IMO you shouldn't be able to spot space ruins by mods' GPS that are being spawned inside a ruin, better to just use a GPS mark for a ruin.

Testing

Ensured they are working (after many hours of testing).
Checked that removing a module from modsuit closes the UI.
Checked that throwing a modsuit away closes the UI.

However I could add something useless or break something so it's better to review the code and point me out if I really did.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: GPS and Crew monitor modules don't anymore spawn a proper item in your hand, instead, they open a UI on use.
tweak: GPS and Crew monitor modules don't anymore require modsuit to be active in order to be used.
tweak: GPS inside a modsuit's GPS module is turned off by default, so you have to manually turn it on.
/:cl:

@kyunkyunkyun kyunkyunkyun changed the title Change behavior when using 2 UI depended modsuit modules. Change behavior when using 2 UI dependent modsuit modules. Jan 4, 2025
@Drsmail
Copy link
Contributor

Drsmail commented Jan 5, 2025

As a blueshield main, i am so grateful for this change 🙏

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting review This PR is awaiting review from the review team label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants