Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borg RCD nerf + migration to new attack chain #27857

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

DGamerL
Copy link
Member

@DGamerL DGamerL commented Jan 6, 2025

What Does This PR Do

Nerfs the borg RCD. It now uses normal cartridges. The Syndicate version for borgs is untouched.

Also migrates the attackchains for RCDs

Why It's Good For The Game

As a borg it's incredibly easy c urrently to just fill the AI sat with doors or other various things. This way you need to actually go back and get more cartridges instead of just getting a yellow core or sitting in a recharger for 10 seconds.

Images of changes

image

It also works when you click on a cartridge with an RCD
image

Testing

See above


Declaration

image
image

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Borg RCDs now take cartridges. Syndicate borg RCDs are unaffected
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 6, 2025
@1080pCat
Copy link
Contributor

1080pCat commented Jan 7, 2025

I don't feel like this'll change much, but free materials is bad, so still a good pr

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Jan 7, 2025
@Coolrune206
Copy link
Contributor

This won't fix AI door spam (they'll just bring over like 90 cartridges and never need to recharge again), but as 1080 said yeah infinite materials bad.

@lewcc lewcc added Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Tweak This PR tweaks something ingame labels Jan 8, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 9, 2025
Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes we discussed in discord (moving afterattack to interact_with_atom)

@DGamerL
Copy link
Member Author

DGamerL commented Jan 9, 2025

Somehow this might've broken using z to activate your borg inhand

@DGamerL
Copy link
Member Author

DGamerL commented Jan 9, 2025

Fixed, thanks warrior!

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Jan 9, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 10, 2025
@Burzah Burzah added this pull request to the merge queue Jan 12, 2025
Merged via the queue into ParadiseSS13:master with commit 848eea7 Jan 12, 2025
17 checks passed
@Forenzek
Copy link

Unless borgs can add materials to the lathe this change sucks.

@Cress67
Copy link
Contributor

Cress67 commented Jan 17, 2025

Combined with MILLA 2, this is going to make fixing breaches more insufferable. Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants