-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes locker breakout message showing the wrong time #27942
Merged
Contrabang
merged 4 commits into
ParadiseSS13:master
from
Burzah:locker-breakout-msg-fix
Jan 14, 2025
Merged
Fixes locker breakout message showing the wrong time #27942
Contrabang
merged 4 commits into
ParadiseSS13:master
from
Burzah:locker-breakout-msg-fix
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
requested changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can simplify it down to this
code/game/objects/structures/crates_lockers/closets/secure/secure_closets.dm
Outdated
Show resolved
Hide resolved
…ure_closets.dm Co-authored-by: Contrabang <[email protected]> Signed-off-by: Burzah <[email protected]>
Co-authored-by: Contrabang <[email protected]> Signed-off-by: Burzah <[email protected]>
Burzah
commented
Jan 11, 2025
code/game/objects/structures/crates_lockers/closets/secure/secure_closets.dm
Outdated
Show resolved
Hide resolved
Signed-off-by: Burzah <[email protected]>
Miraviel
approved these changes
Jan 11, 2025
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
labels
Jan 11, 2025
Rip 2500 minute breakout time 😔 |
Contrabang
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting review
This PR is awaiting review from the review team
Fix
This PR will fix an issue in the game
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Displays the correct time when breaking out of a locker that is welded or secure.
Fixes #27522
Fixes #27370
Why It's Good For The Game
Gives the player the correct information.
Testing
Took control of a mob in a welded locker.
Broke out and observed the correct message and time.
Declaration
Changelog
🆑
fix: Fixed breakout messages for locker displaying the incorrect time.
/:cl: