Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potted plants size categories #28046

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ExusA
Copy link
Contributor

@ExusA ExusA commented Jan 20, 2025

What Does This PR Do

This categorizes Kirbyplants into Large, Medium, Small and Alien, and adds new spawners for each category which exclusively spawn their respective plants.

It repaths all the Kirbyplants into these categories and restricts the special interaction where you hide behind a plant to the large, medium and alien plants, and allows picking up small plants with one hand, and putting small plants in bags.

The new small, medium and alien plant spawner mapping helpers aren't added to any maps, but they may be useful to mappers in the future. The current plant spawner mapping helpers has been replaced with Large helpers, which spawn large plants only.

Why It's Good For The Game

In most places where random kirbyplant spawners are mapped in, a larger plant looks way better than a tiny pot with a small flower in it. Conversely, there are places where a smaller kirbyplant would look great, like on tables and desks, but the spawner can't be used because a huge plant would look silly on a desk.

Almost all of the alien plants look pretty bad in hallways and rooms so having a new spawner will remove them from most places while keeping them available to put in alien places like explorable ruins, science, etc.

Removing the ability to hide behind non-large and medium plants is a bit iffy and is more of a logical thing, but it should have minimal effect on balance, since most of the mapped in plants will be large ones now anyway- On metastation though, a lot of specific plant varieties are mapped in, so there will be modestly reduced opportunities for antags to hide behind plants there.

Images of changes

The new categories of the plants:
Plant 1-17 and Alien 1-8 are considered large plants.
plant categories

Testing

Loaded up the game, looked at all the plants on the station. Spawned in a bunch of different random and specific plants and made sure they matched their spawner type.
Checked the webmap to make sure the mapped in specific plants all had the same icons on the webmap as in game.
Picked up and put down small medium large and alien plants to make sure the hiding behavior worked as intended.
Examined plants to make sure examines were working properly.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

approvalish
approvalish2

Changelog

🆑
tweak: Station potted plants are now bigger and less alien on average.
tweak: You can no longer hide behind small plants, but you can pick them up more easily.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Jan 20, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the Sprites This PR modifies the game sprites label Jan 20, 2025
@ExusA
Copy link
Contributor Author

ExusA commented Jan 20, 2025

I used an updatepaths script for the map changes, this is my first time so I hope I did it correctly.
Should I add the script to the \tools\UpdatePaths\Scripts folder, or does that happen automatically?
Edit: I've added it to the folder, please let me know if that's not right.

@ExusA ExusA marked this pull request as ready for review January 20, 2025 19:22
@Contrabang Contrabang added Balance This PR will modify how effective something is or isnt Tweak This PR tweaks something ingame labels Jan 20, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 20, 2025
@silverplatedelta
Copy link
Contributor

One one minor balance request here, could you add something to the examine description of plants showing if they can be hidden in/behind?

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 21, 2025
@ExusA
Copy link
Contributor Author

ExusA commented Jan 22, 2025

I've added messages to the examines, plus medium plants can now also be hid behind and can't be put in bags, leaving small ones as the only unhideable ones.
potted plant

@ExusA ExusA marked this pull request as draft January 22, 2025 15:32
@ExusA ExusA marked this pull request as ready for review January 22, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Balance This PR will modify how effective something is or isnt Map Edit This PR will modify a map Sprites This PR modifies the game sprites Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants