Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+clicking an item search causes PoB2 to crash (stack overflow) #559

Open
2 tasks done
OrderedSet86 opened this issue Jan 23, 2025 · 2 comments
Open
2 tasks done
Labels
bug Something isn't working crash Causes PoB to crash and is High Priority

Comments

@OrderedSet86
Copy link
Contributor

OrderedSet86 commented Jan 23, 2025

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Linux - Wine

Screenshots of crash/graphical issue, version and options menu

Image

Downloading page at: https://www.pathofexile.com/api/trade2/data/leagues
Downloading page at: https://www.pathofexile.com/api/trade2/search/poe2/Standard
Download complete. Status: OK
Download complete. Status: OK
Failed to test Quiver mod: 19% chance to Pierce an Enemy
Failed to test Quiver mod: 100% chance to Pierce an Enemy
Failed to test Quiver mod: 25% chance to Pierce an Enemy
00c0:err:virtual:virtual_setup_exception stack overflow 1808 bytes in thread 00c0 addr 0x7bc53d44 stack 0x1208f0 (0x120000-0x121000-0x220000)

What are your system specifications and configuration?

NOTE: Running dev branch on wine

OS: Ubuntu 22.04.5 LTS
GNOME version: 42.9
Windowing system: X11
CPU: Ryzen 7 5800x
GPU: NVIDIA Geforce RTX 4070, Driver Version 560.35.05

How to reproduce the issue

  1. Load character build
  2. "Items" tab
  3. "Trade for these items"
  4. "Adjust search weights" -> set "Effective Hit Pool" to 0
  5. "Find Best" for "Weapon 2"
  6. "Execute"
  7. Crash

Character build code

eNrtPWlz27iSn0e_AuWq2dotKzYJ3llntmz5UmLHjuVc-yVFi5DFCUUqPCw7r95_326At0mKsmfmZd5mpsqRCHQD6G70hRa49z_3C4_csTByA__VlrwjbRHmTwPH9W9fbb2_Pn5hbv3Pb4O9SzueX8wOEtfDFvrb4Jc9_oV47I55r7ZMa4tMPTuK3toL9mrrnIVT5tvhwxaxI_jkjIq2E7bwAAc5Y7cwpm-7IdsisR3esvhDNg_piwz45nZoT2MWnuEY-0kcnAcOIIjDBCAWtutPgulXFp-EQbKEuW-RO5etRJ_x-eXF1fUWzPOXvUvPfmDhJLZjEsGfV1v7sF77lh3aC_gLULaXAIgqUW1HUnXxn7G12wl8kIRR_DQMkyVjTg5EdwzNNNv6XobsaDZj09i9Y6PQjUdz258WI2ptcJv2PU-82F16LguLibX1P32EWpakts7XQWx7h5eToq8sS-oOtUxDVbuBgjgHakX_0Y3nBx7Qc9MhEHB867sxewrkZeBGgf_UZZXhWlc2SjzcJr36XrGIhXd27Fbn1I47WNy4_uZE2w-ZfTETAnllO24SnbM4ZFFJmFul5tz27VEQFTzVtK6ul1yDxBUIaQ3AhE0DUDVlEFmTdwxF7TFSM3zrkGfujPXvudFqUoBNZ_O0dRxN-vbbGPHTJnQFGrVfz0mQeD17xmFJV9H2bfSt3FOT2zoesvtC5E2tA1-lp9w68tgvVmFoagfCck-ZdszwLkB1sJ42XCkdnV6WCAS2a0dRdUUxZF1ptUzzh8id2t65fe8ukgUYhWv7KysG1DW1Q1xv57EP2q0N2DR1vQ34GByGNjiqyLLarvU852mAczuIWtepGh06z_VPbd_Zn04TcGUeciBFl5SuvVwwQ9elDj9i-hJ7j_1pQbkutO_9kFuKkvvRNQCCXMHWRY_nxmO9YYphUhXQx1EQg90yPx3xoZ_WO2NsOj8BOl_ZMetnKQp_zWzfkZy42LtMXNnowttA3a4RqiAbUAoBmyklq-pOp63bkFqTpQu-YcmYrunZQAGlN0idArTdtPgsvH2YzF3mOT0MUal3RrGRveyzehCBMnRZFHoOt5E8l0E35BRazU1Hu7OjsoUwZb2bEqJ_LyKcM_DJAcBhtUhBag90gt8xzPE2A9sPF0FSmGzdMjrXILr3WkJm30SMd8WcZFoxqK3EyuO1Aw_C074LyaFgnp63Eeh-HNvTr4eBc9ubbHyQjSCq85skyyXsW5SHvgjQbEOc4kZlT2d95wsQ5vJuVTvNe-8Bis71AbS1TkttEEXqCVEfSer0N2qj9Once4CcmeegKxagdHlK4jwouQU7Cm3nDoSm5dBRMwyVKjsa-IztmQwO1Bz7pvgmX13PIxH-vbRDANkiEezWKeOfOBKN3pOcquSqNOFec7gMVkChOeaaoh4aoNQbvL-C4a1LDJn__aE3_kr3XgMc-Q74kbDdeo9Rh2ga5iCZzSIyDRY3dnwGYoTkvoFn4vMpOH-eQ4IZGU_ZkBRfr-eJ77BwiM_JgRtD49j3eR4CPhZc2g_DYLVFwAOOmED5IfBi252Sczv8ms7h2l2AyYiiQzu2iZMGLx_s0LX9mPLcXsTscDpHBMe2592AxuNikT8V4oL5wGPXi1l4CM9w4UicOkYZMeLAe7s8i4mfxotlEMaE3eM_KH8Pr7Zmthcx0ZE_ATxR7Po80QJ61_O2yGQerPadOxzpOgi8KAMi9nLJfKeC4zpkjNiZFp3iJPji8QtZ2BHM-kFszQhXU8qcjh3MxxE_gAmArJuKZQw105TVIbWoKg1lEH5pSE0VH2uWPFQtXTOGVJZlOpQlWZHhs2WqQ_AQqYWtlj4EN142h7qsSspQU2VqDFXDMvShIgF-7KnqQ02WVBOfSPiX49RMOtQkywQEsqFAd0VRNRhbUtWhamoaHRqWLg01Q5OVoUINXQFcVKfQxVSgo2xoGo4qW0PN0hRzSFUDkBmmZA1Nk8LcTR36gessA3INZ6pRS4POsOChSjUJVqpqMnzWKExOs3RYnUpNA1ZKDRhTNynlKx2qMHP4CMpBg9nqqowIDfirAkVUVcbVqiYuSJFhhZoEyx3KpiEbMENTgQVBCGxCT02HWai6gfMygS4qEBXGA49YhecqfjYMifKVAqxk6PBcASYMIbA0EL8ES4cuSCkL0EAXXCTwCldgAA9h0RQQA1vhOQV6Aqk1joACkTQdmQujahbAqqYCS5YMCWmA6DUNOKHqmqYOQRHKMDNFBpJJSGuqWzCsrFON0xPYbBpIJtkyQFwMCYWGyhS6mLqGpARKoBalMCVgBfAQnioU5qCZuESqKIBD1REppZoyNIDcioWYddmiIEyWBYMrQCdgvaSglMoUemvAJJgrTFke6kAnA_cvZobs8GG_Kuy-C3srhv1SOxIoNgPunF_23l-d8Q-_zON4Gb3c3V2tVjtLO54HM3YPzuQOqLXdJQDBnnvBTcsLxLq7D_8d3I5H7OKdo91oDxdH785H91--Kuap9t6_9b_Kn24vjpXR-Ojwm2HdXd8YccBOp-pN5ATseK6s3gUfzxx39O4jPb-zb2cnF6Pl7EukxP7o9w-Xd3f6C3fy-e2Y3U5ey3ezxLDG8er4zZelbn8--mS8WK0OnNefYjMYf_7y8cB-E0x-p7OzT4uzDyvZD1-Pxu8iS1oZ89ens5M3ydEoOY4_Xt9F-u3F5PtKfn18_Pp3Zhgfvk--f_KPjs-86OLT0Z1x_eL7p8SbvhjZ3y_t98FnS9YPYvXytf4leierJ9FbV6Zz1To7vDx5R7_-76W6_9Yw9OPZhc9kM3Emb6PX9tnUffFpeh6tjsd0FqzObehvSSNp-e3SZJffRtrnL2-OlhPZefdGvvQl-d3-PmfEbsaJPXEoE-2Kb-iThC6oLcGmPXBWQ_cmiVnWADr1_q3Qa1vE9eP0s5DRso5LlQVuA6HdxB5Mdx_XcWL3CSXEBSzVbmLjCe32WK8JIRZboLyFuNLK9A2qKL4RhPiKbSq2ptBRQjsKLSB0JN8tuDeEEhEqSuzyVJdxRZfuE66jhNITKlLsFr4buV5CHyjMKJVSd7dC3r1dtCTcrKGpwQ9vg1i04cPsyx73tCIwl2F8whbRwQN4X8cYddaOBlJbhb0nLBZmuAyTncU5bGYnHj5_l9iei6ZTKj89E4eEfhAu8oQhoALTiYGEwHj9sMSV7Z-dpUYxHZW4TmYo04f86G-_mNrI9qYRn5zrT73EYWM_9Siz-Xn2DY6PR5uYyHLKZ4glRPk4v-zBhLgHBRMYg5dzn2okAX_iBTe2R3PsYnVUqrbLWfudcDpQbRURAbquXB_VHwsXbot8K1Hyli2w2zmLbQccpN1xDBzYhTnu8nkjhSuIfXuRehg1Z7m2_mmQ-Nyr3qosNiUorjiTMz7OE3mQOkR_CRNkawMmpJ7pYzbwho0YET3mRIq9iRdpUzM35FZmCLIAB0rN5Bbc-5g5wm9sW4MryJceFyBDYabPoPJ6Ih9zd1akJtJNXqJ0-qTcaVNy54oDoojYtb1rBg58mdzpc5I2bErs3T-VPB-ZvQz8I49H31mSqZVOjb2fTLDL0AU1vA-6eMHzrQXJRAspmn4souXhZSuh8h4batGcNjmCMllKD38wgkwZBt7t5BDtT5aUFL5CizTYfyop_j6mpI89F9mQi1maCylxoNbyRGPyCH_BiEeJmJ8cKdN9jDnpR9yAp8_kBMfbxAXe8JMDEEGAUb_wJ3MIA0scQNqWWp7IhQruggv4mAQ-SRv-QiXdhyAHtuflblmJJJXnTyRIDXdBEmwgpZafkpnnnXnauWBD6enTYq8K2oIDlSz38-mffoSuPMAXITx-5EC8x9hfJjGfwauthRtNv2AWH-theeqAV_QeHR8fja7HH47SvHsZhFPki58sbril4f_mMcPehPHzTxIlN5H4CEt02YpP5BCo43oRrsvz7GXE8sQ3D9_TmXsA14GN9zp186raZlxFh3ZMR_cMfH__9qMdTkOXtc4rb18zKTEgnqvjOUUbNixYbUckohzUVOJEv4VSvDa4HQvW6rYuBxs7YMeLpe21jpy2rqFEjFkaEG935k4xDO1mOeZ0RK8OuuS1Ua38To-Y23HwCuA2BKKxHVjU8rZBp60dVOVFxK1UFa3t4IdsareuXTS2A-dFIoF_inU6zVjyXh2Y3gY-F3JMHLgeBn-tnIUwNO_SjvAinrMwPcxqw3QOOirr0rlxRMa4FU-pRweteFldC4WwrR1UFI21rAHbOjZNWkHVttvd7i1brXRq4Ue5TzsqUSLQSsO03KCDDWmlTQsLRGvHSrJqo5ZFpM0dG4Xr4P27wHVEwUnLlql161Ia3Fl8LhpeRfN8NPWymudjPPbs6Gsrv9PWdvD3sYs-UAMW4cH0QoIb63kYcH89DwNWPiyeDH1Vd0UK2KtuJySv0WgEzlq79n5auvFkDKLA5MngvP7lydDcAByyGYMVdFqAvE_H5ogT_xCIEXdsjJ6o-LSatUixuo1wCVvYuNKNMYrdnRaYdykA0WUNIjDmpx3uYj9Mea3YKbM9_OVT4D0P4aNC-ucgw3LXZGn7TobuYp2T3o98QRwBUl4cdIhltc8los8WDw2ICgGp49nbzeI6XjaEkVZa7DSJQwymvwfB4vOrrReyZexohkw1y1JVSREN6YGrkR6yggt-6AIfQy5_2bDY8RNg0GV1x1AkRZENxbLSwige5qYHwPg5P_9tx5dETPzQRxxXcAhBKRFqApbyYe4VBObxw0vy_u343fujwf4teKhRTGBPkUMImX2wgwPk5IuzAB4fuvYCUA84Fr68l8SkA_ErtJfkDNXR4MxdgLftkDh4SeQBRDSeO4UN8JJIg8kCEyKXohKEpAfgrk8EAgLTDMRRGlF_JSFW-wIe4b2TTPVgiukhSAZvgxiD-V7Y0O9GlMGMCBYTOyJH93FoE6xBTR_yWB8i9Svbhx4h_n21Je1oWynB0mxAa4_sRwY8O1GlNq1S-2r_6mgArk_gkH0QpsHR_RJiZVgizJnnCMhBsKpSWR6kp_ovCQVCivKOl2RCJoOrxGfwKUg8WE3IcJUjN7YxfxLE3rpmPsAV-_aSGGaZW3TwDxAsCPrif_4jBBT_1KVfMb0UMht2DcnPwTKKrtx4TkR8HQ1g-tlnMnNhUNsntuO4yEB-thXC-vYdJyJUBkEhlBKsNs4YwVtUDVsMs8IiAYMNmlwqb0xbZbM8RTEBwqP5wbaCQHyxSAEuh3m1eyo8_ab9x0hJRw9lbQ91bQ9tbQ99bQ9jbQ-zXeKVZv0Sf4dg6z9AM0X_HYE6iRzYmYMTZPDIDaceiwcikiIilHpJNLN1H5S3QSrlEEGzkkSrUlX_bKsSSsFCGD-Cbu2AVsRazJcfJXDdOwsS0HdUK-uOGO0DuXnAijYGeqQ84QFXNYrE-6dGlqADXmic7GkVDrZmmCxBb_5A8tXEV7VBk1169m3CyAGgcQYTFoKiBlK-S0Ath3VbUWKOWmaOPMg23twGbS7TX_HqAbBsyLCpDWaN8BwS7HahBLjeUNSSEnBS9gS5GlKUMm_Ligp3errpFaPcqawUhOKgPRTHNjWw1yG7jxkSRoiBJjgPup1w34O8gc4_FIf_Gg3SJEdagxwdLZYPwAaffLRDJzOKeOnFDEtnQjAENugHkaQAiTEstSpd0jobOQ7BecCPj74XYqlrnVZQragLkXEZknRSYC-c2r6meuHJTLxghYJ6GcSAlGuZQ3bDC_8B9jM4NdtUVVGQMnxXNmbQB1bV9FYbtzVu2kQaC-yc9SsX2KLmjCeVcCvBZIRE8h-psdSfQvEUFcAoxlyOMdQj1_OQgaPpOT8tXi-LpzdI9P5t4D8QnvwQVm5_kaCRK4utYZWlT26Rvn3PC6agV8FqQsQQ4RHZAJXkOtOV7gjyn2ngS2Bp7sxlYfRfL8k2GL-BanUJl26VLWZVtqseYXOfbYOLI6rNwmUsRDJCm8x7cP-vJKvbqLzhOff-Ss__dGH8wUSto4fVLoxGgzBOAo9cJ6E_OACOTefkChncLolS1TxnbksmUG5ENJCeXL5Sb7siXthBeOwmt9Y6yX7QmftShbHmHbkqM6xOq74tAyL8nh5aZbJa9f6bt8M21auGeptajeL3U-f10Xlmg5hhRpa88ZPpV4-1ihrY6meJmjhqeixtKX_rorEta_SR568qPeRFppn6Kg64QGdxOR37MfM895b9AQLzN3DZrKYkRohJDNAsLPPXzmx0dQ6CII4KX02hSpX9SourljpmJ549xbLhTt9Mrvtm22gQG0yGopUZnf3cNvXvddrf_HGx2VakmgpR5XaXC1wq86dL1ShPstQgUCceuDfgPNhcfZzbrkcOmBcPuA-FHrTgfG9dIpcyifyciaSnJpgpRfeEM1P48cAsrcxu9JUHilyWDzENkY7PU5IgEkazD0PNRoHMfJtGifkpGngPWlU0zvdPxiNQNkgv2EU2D6MEL0BhY7b6OPBcTAGWBUMxy8miQkaoWZWR98jZ1ZzxxDK5gVhoAQjD4DvzB2d2FKNbIpLq0WAU-FGyAPExJRwa_mbyBFoDRGowSsIQtIv3QOZ2VGofnGAqOiLjxSLx0dKgvISMfWdpssAgJwnEvcRJeAZYyBhvi4i0I2v5QBiwien8iZZdpo0JPLxICdf90Y0c2Kf4bZ8frwyOkxCPKcjH0F6WND_sx1pGr24K1HVRe8UYdNoHjXbbB6o2b0dZqzuF6iP7rrSlljk_QHEU4EV-SpYeJalLniyHhC6VcX7EROB6RdAoQkqDfv_g3rkOOQ2W4DAseN12NQTRqhlbuSs4NboOJAYVoz8KgOfBCkDTq3kQB9qX8Gt2ciTyjpUYQhTb1rX9j52gldWW0G-UxIOJvVzOwUjVw74Kzc2awQuijKQp8QhN09u-jVoPs5qDc9cH2kTEYcABNLr1vGuVW0Vu1_VnMHRMsnK2H528TYnLy3nAfPce9AHIUzORFb0m2Nr63ElV-IWxIPw4PFkOqjTuoGfV-bXxNDVx-DFgerKKRi-F-tGJrzeeo3KvAMW7SaOYUhfhHx0hWp2HAWr7-aKIAYojnx_as2skrtEl2bEdNpKX0ip5aUeoVZXnQmT5L0ZqjKlF8PmpTVQT_IpAc0R_J3k2G52sA4_LFQSMI4gX4wG6VEtY6wmsGXxdbzEQ8Qq4OOAxVVS53uzxyjXto9HHpxg8f5aFSlx-00qK6p6YxODe3sbzGh8K70euKPp_V9-mKRnyIQhjdk8ObJ_1KemgG5V0vEvcZeDZzQUdRWNbOYdSd4ZlqVWX5T2t8iEs6FlxurVwRbQzd-N-FRN1JQvy-EKzBvhLCZ4LPnVjIn5eAC78joRJ45KDLEIdgNlRaC1bU8smlxxvzXqs2k25fwHL08pF6KO1RyK4g_CAe0uPjoJ_qB3xB55JdK1FWt9l_XrlrmorqVGtfnQhApjbrgeShwbj0YaUmmtLnl1i1RWTblJVRbVKEHoT-AkWoGDNHnydhRCQH30DTbAsqi_-aPlqJHdjsga2ixcADoe892J3YWO2HreASMKlWZsPLHSAFl16sS37K2XRSEQUg6bBCAYnDbkamedqDK07V1O0DyzQfIuAJ_PScNGd8YQhWc1RAQD8GWx-ng_OMjRU2jhD8ywTRJszNOdB6AYh2N078H8SkXbCbMctkNTOHQdNMoocjarTepJGNnpnacT_z9wif2pz_wMELPTqPK2msrJZ_YdWs7LpEZIQEU5FPHuCwUkQFiuAcEIqijrWdf671I7RpoTQIc_3lw6QJq4HjoiHaiyMHsmlYvRzojKZiINwUU8TGlKvY6TGGK7zLCk9fWyO5quFhrUqCQFYcZazSp5Hhwqq0pLFVH8eND0x203VnwfZ_38OsmlTDu8co5tz5gCFMMl7Zi-BW2m51sgGO_AQxWVV85wSLu6sHOBVu4Kn5iMmrBMRLNzaVs12bVOt6mqpzZI18_Hxtmw1CYpiPVZQ_6rSmX-LCi3amMsM3UUUB2DgTxLXwYCWX2rsdOURQPj-9J-GaNpf-9MQ1Vgb5qtcnxnS45-HcJmWqbrh70OUWgW3OK5V6zXcp278N81j_QvNq_EzW_YzW_YzW_ajZcvwZt_2H4xWL_0Fi0BcgLm8eX91hr99FfcVnXgQAkVbvGlcGqkdQoxD5AKGGutgRNKoBJJTRSiCsQPd-c382Mhvjc9AX7MVSGX6qIx6zZDC9StNUlsHIeqRlKZJdkKUllWwspsStDQvuYsU_IUDVVKkjzYgRcqx0qBqN_lVvAG4Sn7-aIMxseivRJdOfvN78qsDpo-aBmyaMb4HoDZj8WhzKslkssLXv_QWAgwpy7Q1umaKb3WoTlQ86blQ_oaJKnz6aBPWBM4DyW6iycWQdo6LL1eojSsePUEMn0Tg0iYz-21LusEQp8xblJWFbHZRg7-Po0qN9NFGXAjikt6lSlnDiwvq8NYC2wH1jjcWfGRo4aMUKb6cZsWf4EuH-TunpfySQLw7kPC756uvGtptAQYzUwDnV1VwR0XcVFF7yWU60cbJifmLO_UCf-beptcfiC_pBQgcPn9CYjf2GF7Uxa-6r9qtS8-eMsyEgS8hCMfQo0hf_5zdr2dIOYtbACqvg8rA1gHlTlV2m15-n59U7Je2AUsvj87AtDUw5dd75TBrVwZPnjA_HOsJYNxJLCBMtb3_In8dNr7tmYXMmfDb-_DWxgnzZqVxtR5r3JgwxbWgeEFKBqb0hdqcEShidZKqkrUGLL_UK6dpF1E5SPW1ehuLJYKCMua3g3CWRAUK2kfc-hKU1_PUR5A7-k8DfjdLbwA-o_TlgoHncee5rBXWQGZGMB-JmpbUg4B1uisdQJF763oXM34PFKyMX2bVd2W4R_vSejTH60GbSbe3mytbcSsO__bbYG8Xf519MeM1iSDy9LfB_wFQEwJA
@OrderedSet86 OrderedSet86 added bug Something isn't working crash Causes PoB to crash and is High Priority labels Jan 23, 2025
@zao
Copy link

zao commented Jan 23, 2025

I didn't debug it on Linux but I could reproduce it there.
Squinting at the trade URL that your search generates it's 2481 characters long.
SimpleGraphic uses ShellExecuteA with the open verb to open URLs, and supposedly the limit for those is surprisingly low, around 2048 characters.
We should either validate our parameters to reject the call or find another method of opening a web browser.

@Wires77
Copy link
Member

Wires77 commented Jan 23, 2025

Definitely reject the call on the runtime side. On the Lua side, we can probably trim off the bottom-weighted filters until the URL is below 2048 characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Causes PoB to crash and is High Priority
Projects
None yet
Development

No branches or pull requests

3 participants