Recoup doesn't seem to do anything, and has wrong duration #353
Labels
bug
Something isn't working
Comments
|
I forgot to explicitly mention above, but mana recoup also does not work (eg Midnight Braid) despite showing as blue: For mana recoup it is also "Mana Recovery from other Sources" so % increased mana regen modifiers should not apply to it. That includes MoM and various small passives. Nothing shows at the moment anyway, just noting for implementation. |
|
@Regisle Seems like you wrote most of the code for recoup, you might know what is going on |
|
Taking off Stasis Prison makes Life Recovery go up, which implies Recoup isn't being calculated: Build code (PoE1): |
|
Update: from Discord discussion, it is computed in the Calcs tab, but not shown in summary:
With that being said, I'm not really sure how to actually compute using Heartbound Loop. If I put in a custom modifier like so: It is calculated as a DoT, which does not apply armour, only additional flat PDR from gear. This means that this item will not work (it's red anyway for now but since phys/s is a DoT, only the PDR would be "prevented", which would give incorrect recoup values): Is there some other damage method I'm supposed to use to indicate that the damage is coming pre mitigation, and is a Hit rather than a DoT? Build if you want to look at it: The idea here is to stack armour and fire proj, you can easily get regen values in excess of 10k+ in game. A simulation of the build here: |
LocalIdentity
closed this as completed
in
PathOfBuildingCommunity/PathOfBuilding-PoE2-v2#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check version
Check for duplicates
What platform are you running Path of Building on?
Linux - Wine
How is Path of Building expected to behave?
Many recoup modifiers on the tree are marked as blue (non comprehensive list of examples):
Therefore, I expect to see recoup added in "Net Life Recovery" when adding damage to myself.
How does Path of Building behave?
When I perform the steps listed in the reproduction guide, no life recovery is added:
Since adding Taut Flesh from default ranger class gives 15% phys recoup and 9% all damage recoup, expected recoup magnitude is 24 life over 8 seconds. This should be 3 life regen, and would ramp to 24 life regen after 8 seconds of taking phys damage (since each instance of recoup applies independently). I'm not sure which one should be displayed, but I think it should probably be the ramp value (as this would be most accurate for builds that are likely to use recoup, eg. Infernal Flame or Heartbound Loop CWDT builds. Example for reference: https://www.youtube.com/watch?v=vCnW8OSUMMA (see end of Xesht clear for massive health regen from recoup)).
Additionally, when hovering Recoup in Calcs, it says over 4 seconds.
This is changed to 8s base in PoE2:
Another note for implementation - recoup does NOT count as Life Regen, only Life Recovery from Other Sources. Therefore, these do not apply to recoup (tested in game):
Not tested but likely follows the same rules:
However, this does, as it applies to Life Recovery (tested in game):
How to reproduce the issue
Character build code
Screenshots
No response
The text was updated successfully, but these errors were encountered: