Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new dataset #1

Open
rehmatgulvi opened this issue Dec 19, 2024 · 5 comments
Open

Adding new dataset #1

rehmatgulvi opened this issue Dec 19, 2024 · 5 comments

Comments

@rehmatgulvi
Copy link

I greatly appreciate your contributions and the time you've dedicated to this project. I plan to use this code in my work, as I have conducted experiments similar to the Palestinian dataset and now wish to include the dataset named "ind." I’ve already added a subfolder named "ind" within the data folder and made the necessary changes to the code.

While I managed to simulate the code successfully—Streamlit launches, and it displays the data and animations—the issue arises with the fundamental diagrams. Specifically, I encounter an error message stating "something went south." Additionally, the ind.pkl file in the app_data folder is empty, and the proximity_analysis_results_euc.csv file does not include the "ind" data.

I suspect the issue might lie in the code being restricted to the provided countries, or there may be a specific part of the code that I need to modify but haven’t understood. Could you kindly guide me on what changes are needed to resolve this issue? Thank you for your support.
indian pkl file size
fundamental diagram error
data folder
Trajectories

@chraibi
Copy link
Contributor

chraibi commented Dec 19, 2024

To Calculate "proximity_analysis_results_euc.csv" we don't use the app, since the calculation takes some time.
There is this script that has to run before to calculate the proximity results as csv file.

You should put your data in the same file with the other countries as shown in this line of the script.

@rehmatgulvi
Copy link
Author

Thank you so much. I was confused about the output CSV file. When I run the code, I got proximity_analysis_results_arc, and when I run it using Streamlit, I got proximity_analysis_results_euc. I hope both are the same?

@chraibi
Copy link
Contributor

chraibi commented Dec 26, 2024

Nice that you made progress.
Actually, "Arc" and "Euc" are two different methods to calculate the distances between neighbors.
In the first tab of the app, you can see a short explanation:

Screenshot 2024-12-26 at 19 32 48

Notice also the title of the plot: It shows both distances. It's a small difference, depending on the density.

According to this line
the file name reflects the used method, which you define in this line.

If you have other questions, please do let me know. We are happy that you find this work useful and helpful for your own research.

@rehmatgulvi
Copy link
Author

Why do we have only one CSV saving option for proximity_analysis_results_arc, and how can we save the Euclidean analysis results without using Streamlit?...Thank you sir

@chraibi
Copy link
Contributor

chraibi commented Dec 27, 2024

Because these calculations take some time. So, we decided to do it in the script this way, without need to use the app.
(streamlit is slow).

If you need the file for the Euclidean distances, then:

method = Method.VECT

For arc distances

method = Method.ARC

If you use the script as is, without changes, then you should get EUC-distances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants