From 57621671862fb468bbae3efbdfee9f6d9ef7846b Mon Sep 17 00:00:00 2001
From: "Cameron (3539)" <theforgelover@gmail.com>
Date: Mon, 18 Nov 2024 02:10:40 -0500
Subject: [PATCH] Test way too many calibration points (#1585)

![image](https://github.com/user-attachments/assets/508674fe-1d5e-41bf-a115-23bcf1638da0)

Limit seems to be at -least- 700,000 corners in my testing. That's
enough for anyone, surely.

---------

Co-authored-by: Matt <matthew.morley.ca@gmail.com>
---
 build.gradle                                         |  2 +-
 .../src/components/cameras/CameraCalibrationCard.vue | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/build.gradle b/build.gradle
index aa4d5c9354..17155080e5 100644
--- a/build.gradle
+++ b/build.gradle
@@ -39,7 +39,7 @@ ext {
     libcameraDriverVersion = "dev-v2023.1.0-15-gc8988b3"
     rknnVersion = "dev-v2024.0.1-4-g0db16ac"
     frcYear = "2025"
-    mrcalVersion = "dev-v2024.0.0-24-gc1efcf0";
+    mrcalVersion = "dev-v2024.0.0-27-g41d7868";
 
 
     pubVersion = versionString
diff --git a/photon-client/src/components/cameras/CameraCalibrationCard.vue b/photon-client/src/components/cameras/CameraCalibrationCard.vue
index 03ee393e56..57057da537 100644
--- a/photon-client/src/components/cameras/CameraCalibrationCard.vue
+++ b/photon-client/src/components/cameras/CameraCalibrationCard.vue
@@ -82,6 +82,11 @@ const boardType = ref<CalibrationBoardTypes>(CalibrationBoardTypes.Charuco);
 const useOldPattern = ref(false);
 const tagFamily = ref<CalibrationTagFamilies>(CalibrationTagFamilies.Dict_4X4_1000);
 
+// Emperical testing - with stack size limit of 1MB, we can handle at -least- 700k points
+const tooManyPoints = computed(
+  () => useStateStore().calibrationData.imageCount * patternWidth.value * patternHeight.value > 700000
+);
+
 const downloadCalibBoard = () => {
   const doc = new JsPDF({ unit: "in", format: "letter" });
 
@@ -413,12 +418,17 @@ const setSelectedVideoFormat = (format: VideoFormat) => {
           </v-col>
         </v-row>
         <v-row>
+          <v-col v-if="tooManyPoints" :cols="12">
+            <v-banner rounded color="red" text-color="white" class="mt-3" icon="mdi-alert-circle-outline">
+              Too many corners - finish calibration now!
+            </v-banner>
+          </v-col>
           <v-col :cols="6">
             <v-btn
               small
               color="secondary"
               style="width: 100%"
-              :disabled="!settingsValid"
+              :disabled="!settingsValid || tooManyPoints"
               @click="isCalibrating ? useCameraSettingsStore().takeCalibrationSnapshot() : startCalibration()"
             >
               <v-icon left class="calib-btn-icon"> {{ isCalibrating ? "mdi-camera" : "mdi-flag-outline" }} </v-icon>