Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout on submit #92

Open
simbesh opened this issue Nov 14, 2023 · 4 comments
Open

Timeout on submit #92

simbesh opened this issue Nov 14, 2023 · 4 comments

Comments

@simbesh
Copy link

simbesh commented Nov 14, 2023

Hello, I'm using this package to submit a Plasmo extension in my GitLab CI pipeline, but the default timeout is too short,

in dist/index.js I see there is a retry overwrite param:
submit = async ({filePath: e, version: t = "1.0.0", retry = {retries: 8, delay: 2400}}) => {

but it is not there in the types declaration file, nor does it appear to work when I try and pass a retry object to submit().

My current workaround is to move the submit method into my deploy script and add a longer timeout, would you accept a PR to add this to the submit signature?

@lnoss
Copy link

lnoss commented Dec 19, 2023

Currently meeting the same problem.

🔴 ERROR  | Error: firefox: Step 1) Item ""6def1df3-6313-4648-a6ca-945b92aba510" (No Google Search Translation)": Upload has not been validated in time.

Not sure if the pull requests are actively reviewed. Gonna wait maintainers even before reviewing the current problem.

lnoss added a commit to lnoss/no-google-search-translation that referenced this issue Dec 19, 2023
Timeout value is too low, submit process is dropped.

Refs: PlasmoHQ/mozilla-addons-api#92
@rustyzone
Copy link
Contributor

Also seeing the same issue

@mik4ik
Copy link

mik4ik commented Jul 25, 2024

I have the same issue.
The fix from @rustyzone works for me, hopefully it will be merged soon 🤞

@louisgv
Copy link
Contributor

louisgv commented Nov 13, 2024

Merged -- sorry about the delay folks, didn't see reviewer tagged xD
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants