Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17-1.21 Support #545

Closed
ghost opened this issue Dec 25, 2021 · 17 comments
Closed

1.17-1.21 Support #545

ghost opened this issue Dec 25, 2021 · 17 comments
Labels

Comments

@ghost
Copy link

ghost commented Dec 25, 2021

Add 1.18 support

@rom1504
Copy link
Member

rom1504 commented Dec 25, 2021

#518 we need this first

@ghost ghost closed this as completed Dec 28, 2021
@rom1504 rom1504 reopened this Dec 28, 2021
@ghost ghost closed this as completed Dec 28, 2021
@ghost ghost reopened this Dec 28, 2021
@rom1504
Copy link
Member

rom1504 commented Jan 28, 2022

currently at 1.16.3
#518 for updating to 1.16.5
then 1.17
then 1.18
mineflayer already got all the traps, so just got to follow the same path

will give $50 from https://opencollective.com/prismarinejs to anyone doing this

@rom1504 rom1504 pinned this issue Jan 28, 2022
@rom1504 rom1504 changed the title 1.18 Support? 1.18 Support Jan 28, 2022
@rom1504 rom1504 added the funded label Jan 28, 2022
@rom1504
Copy link
Member

rom1504 commented Jan 28, 2022

@rom1504
Copy link
Member

rom1504 commented Apr 18, 2022

increasing funding to $100 total (from prismarinejs opencollective)

@rom1504 rom1504 changed the title 1.18 Support 1.15-1.20 Support Aug 28, 2023
@rom1504 rom1504 changed the title 1.15-1.20 Support 1.17-1.20 Support Jan 6, 2024
@rom1504
Copy link
Member

rom1504 commented Jan 6, 2024

We got 1.16.5 support thanks to @Pandapip1 now!

Next here is 1.17 1.18 1.19 1.20

@rom1504 rom1504 mentioned this issue Jan 6, 2024
@Pandapip1
Copy link
Contributor

Pandapip1 commented Jan 9, 2024

Can I request that @GroobleDierne get 13% of the current bounty for this issue and that I get 7% of the current bounty for the 1.16.5 support? (I'd say that @GroobleDierne did about 65% of the work for 1.16.5 and that I did 35%)

@rom1504
Copy link
Member

rom1504 commented Jan 9, 2024

Sure. I'm thinking to wait for a few more versions to be supported to give the bounty for here since it seems to be moving fast. And I guess we could increase it too since this issue is pretty important

@rom1504
Copy link
Member

rom1504 commented Jan 9, 2024

I guess let's increase to $200 for everyone doing the work from 1.16.5 to 1.20

@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024

im doing at moment 1.19.2

@rom1504
Copy link
Member

rom1504 commented Mar 29, 2024

This is blocked on #650 (comment)

Please help fixing this first

@extremeheat
Copy link
Member

extremeheat commented Dec 28, 2024

Remaining to do up to 1.20 (1.20.5 is going to need fixes in mcdata)

  • 1.16.5 (version: 755) done with Add 1.16.5 support and future-proof version system #645
  • 1.17.1 (version: 756)
  • 1.18.1 (version: 757)
  • 1.18.2 (version: 758)
  • 1.19 (version: 759)
  • 1.19.2 (version: 760)
  • 1.19.3 (version: 761)
  • 1.19.4 (version: 762)
  • 1.20.1 (version: 763)
  • 1.20.2 (version: 764)
  • 1.20.4 (version: 765)
  • 1.21.1
  • 1.21.3
  • 1.21.4

@rom1504
Copy link
Member

rom1504 commented Dec 28, 2024

#650 is almost done for 1.17

@extremeheat
Copy link
Member

#662 will add 1.18 and 1.18.2 support

after that extremeheat#1 is in the pipeline for 1.19, 1.19.2, 1.19.3 and 1.19.4. Notably 1.19 adds chat signing functionality which isn't essential for now, but will break the tab information packet for a bit. Will come back to this later as mentioned in PR description.

and for 1.20, I have it working up to 1.20.2. 1.20.3 will require some fixes to minecraft-protocol as describe in PrismarineJS/node-minecraft-protocol#1362 and also have to account for chat messages which are no longer sent as JSON but NBT format.

@rom1504 rom1504 changed the title 1.17-1.20 Support 1.17-1.21 Support Jan 4, 2025
@rom1504
Copy link
Member

rom1504 commented Jan 6, 2025

We have 1.21.1 support thanks to @extremeheat now

Next step here is finishing 1.21.3 support in mineflayer PrismarineJS/mineflayer#3489

@extremeheat
Copy link
Member

extremeheat commented Jan 6, 2025

Nothing really interesting in 21.3 btw for those wondering, there were just some fixes made to various things (that are now proper "holderSet" type / should have been this way) that need to be supported now elsewhere.

Maybe the scope of PrismarineJS/minecraft-data#948 is a bit too big now but I guess it's not that bad over possibly creating merge conflicts updating many things out of sync

--

Of note:
https://github.com/extremeheat/extracted_minecraft_data/blob/client1.21.2/client/net/minecraft/server/network/ServerGamePacketListenerImpl.java#L948

a movement check block that needs to be disabled with gamemode

@rom1504
Copy link
Member

rom1504 commented Jan 8, 2025

Only 1.21.4 to do and then we caught up with Mojang

@rom1504
Copy link
Member

rom1504 commented Jan 8, 2025

This is now done

@GroobleDierne and @Pandapip1 did 1.16.5 that started the process
@extremeheat did most of the work for 1.17 to 1.21

Let's grant $30 to @GroobleDierne
$30 to @Pandapip1
And $140 to @extremeheat

To collect it please go over https://docs.opencollective.com/help/expenses-and-getting-paid/submitting-expenses and expense to https://opencollective.com/prismarinejs

Make sure to mention the specific PRs you sent and this issue so that the expenses are accepted as valid by open collective admins.

@rom1504 rom1504 closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants