fix: use dimension data on 1.16.2 #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are passing locally and I can't scroll to the error on the github (seems logs are too large)... |
rom1504
reviewed
Jul 13, 2024
| @@ -261,7 +261,7 @@ function inject (bot, { version, storageBuilder, hideErrors }) { | |||
| bot.world.setColumn(packet.chunkX, packet.chunkZ, column) | |||
| } | |||
|
|
|||
| if (bot.supportFeature('dimensionDataIsAvailable')) { | |||
| if (bot.supportFeature('newLightingDataFormat')) { | |||
There was a problem hiding this comment.
this is for 1.17 https://github.com/PrismarineJS/minecraft-data/blob/8a8c811c71790d75ec405429e5b50343cb77f88b/data/pc/common/features.json#L785
that contradicts the PR description
which is right?
There was a problem hiding this comment.
that contradicts the PR description
Didn't say anything about this change in the pr description, but this change is correct: loadParsedLight is available starting from 1.17 (new lighting format)
|
What user input does it wait for? |
extremeheat
approved these changes
Aug 16, 2024
|
@rom1504 Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dimension packet is available starting from 1.16.2
finishing PrismarineJS/minecraft-data#877