From 3701b6ffb9081336ae4fad9fa87638cd0a26a7b4 Mon Sep 17 00:00:00 2001 From: Maarten ter Huurne Date: Tue, 16 Apr 2024 06:36:09 +0200 Subject: [PATCH] Suppress mypy errors in field tracker tests I can't find a way to inform mypy of the actual types without duplicating a lot of test code. --- tests/test_fields/test_field_tracker.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/test_fields/test_field_tracker.py b/tests/test_fields/test_field_tracker.py index 4ee77608..ec5b899f 100644 --- a/tests/test_fields/test_field_tracker.py +++ b/tests/test_fields/test_field_tracker.py @@ -97,7 +97,8 @@ def setUp(self) -> None: self.tracker = self.instance.tracker def test_descriptor(self) -> None: - self.assertTrue(isinstance(self.tracked_class.tracker, FieldTracker)) + tracker = self.tracked_class.tracker # type: ignore[call-overload] + self.assertTrue(isinstance(tracker, FieldTracker)) def test_pre_save_changed(self) -> None: self.assertChanged(name=None) @@ -529,14 +530,14 @@ class FieldTrackerForeignKeyMixin(FieldTrackerMixin): def setUp(self) -> None: self.old_fk = self.fk_class.objects.create(number=8) - self.instance = self.tracked_class.objects.create(fk=self.old_fk) + self.instance = self.tracked_class.objects.create(fk=self.old_fk) # type: ignore[misc] def test_default(self) -> None: self.tracker = self.instance.tracker self.assertChanged() self.assertPrevious() self.assertCurrent(id=self.instance.id, fk_id=self.old_fk.id) - self.instance.fk = self.fk_class.objects.create(number=8) + self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment] self.assertChanged(fk_id=self.old_fk.id) self.assertPrevious(fk_id=self.old_fk.id) self.assertCurrent(id=self.instance.id, fk_id=self.instance.fk_id) @@ -546,7 +547,7 @@ def test_custom(self) -> None: self.assertChanged() self.assertPrevious() self.assertCurrent(fk_id=self.old_fk.id) - self.instance.fk = self.fk_class.objects.create(number=8) + self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment] self.assertChanged(fk_id=self.old_fk.id) self.assertPrevious(fk_id=self.old_fk.id) self.assertCurrent(fk_id=self.instance.fk_id) @@ -558,7 +559,7 @@ def test_custom_without_id(self) -> None: self.assertChanged() self.assertPrevious() self.assertCurrent(fk=self.old_fk.id) - self.instance.fk = self.fk_class.objects.create(number=8) + self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment] self.assertChanged(fk=self.old_fk.id) self.assertPrevious(fk=self.old_fk.id) self.assertCurrent(fk=self.instance.fk_id)