Bitfields have undefined byte order/endianness

[extremeheat]

Whether or not bitfields are encoded as little or big endian, reading back in the wrong order will cause bitfields to be incorrectly read. Right now they are implied to be big endian, which should be added to the doc.

A way to specify little endian could be helpful, as numerical encoding in any non-Java/JVM language is little endian by default. Also, would be nice to have a explicit note that the highest bit on a unpacked integer should be the sign bit in two's complement.

[rom1504]

Yeah we should definitely support both endianness. Is this needed for bedrock?

…

On Tue, Sep 26, 2023, 11:52 extremeheat ***@***.***> wrote: Whether or not bitfields are encoded as little or big endian, reading back in the wrong order will cause bitfields to be incorrectly read. Right now they are implied to be big endian, which should be added to the doc. A way to specify little endian could be helpful, as numerical encoding in any non-Java/JVM language is little endian by default. Also, would be nice to have a explicit note that the highest bit on a unpacked integer should be the sign bit in two's complement. — Reply to this email directly, view it on GitHub <#49>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437QFLZ6QGMCCLZM3X4DX4JGOBANCNFSM6AAAAAA5HBFXLM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[extremeheat]

No, it's not necessary, I just ran into this issue writing https://github.com/extremeheat/protodef-cpp