Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable or limit the check whether the prover listener port is open #1574

Closed
winlin opened this issue Jan 18, 2022 · 8 comments
Closed

Disable or limit the check whether the prover listener port is open #1574

winlin opened this issue Jan 18, 2022 · 8 comments
Labels
network A network-related issue testnet2

Comments

@winlin
Copy link

winlin commented Jan 18, 2022

💥 disable or limit the check whether the prover listen port

We run prover in home network, and the operator just disconnect the prover because we can not set the NAT or port forwarding in our router. As the help from @HarukaMa, we disable the check for port in operator and prover. Indeed, it not easy to do the NAT and port forwarding in home network, so we suggest disable the check for prover.

@ljedrz ljedrz added network A network-related issue testnet2 labels Jan 18, 2022
@ljedrz
Copy link
Collaborator

ljedrz commented Jan 18, 2022

In addition to this, there used to be a proposal to use UPnP for automatic port forwarding for testnet1. I'll try to revive it for testnet2 shortly.

@ljedrz ljedrz changed the title Disable or limit the check whether the prover listen port Disable or limit the check whether the prover listener port is open Jan 18, 2022
@ljedrz
Copy link
Collaborator

ljedrz commented Jan 18, 2022

I just filed https://github.com/AleoHQ/snarkOS/pull/1575 that should aid port forwarding with UPnP-enabled routers.

@winlin
Copy link
Author

winlin commented Jan 18, 2022

ok, it should be an option logic, not default logic

@wanyvic
Copy link

wanyvic commented Jan 20, 2022

https://github.com/AleoHQ/snarkOS/blob/506fcbf33d555a528efcec6c0fc1fe5c21902f22/src/network/peer.rs#L234-L248
Consider whether to delete this lines?
I run node behind NAT in home. ISP give me a LAN IP (such as 10.0.0.1).
My node listens 0.0.0.0:4132. but remote is x.x.x.x:9157. It can not be connected successfully with this lines. but I'm not sure if it will have some ploblem.

@ljedrz
Copy link
Collaborator

ljedrz commented Jan 20, 2022

@wanyvic while this suggestion is being considered, have you tried the workaround described here?

@wanyvic
Copy link

wanyvic commented Jan 20, 2022

I had tried https://github.com/AleoHQ/snarkOS/pull/1575, The problem still exists.

@wanyvic
Copy link

wanyvic commented Jan 21, 2022

    +------------------------------------------------------------------------------------------------------------+   
    |                                                                                                            |   
    |                                                                                                            |   
    |              public IP 113.30.25.32                                                                        |   
    |      +----------------------------------------------+                                                      |   
    |      |                                              |                                                      |   
    |      |             ISP NAT                          |                                                      |   
    |      |                                              |                                                      |   
    |      |     +------------------------------+         |                                                      |   
    |      |     |       my home router         |         |                                                      |   
    |      |     |                              |         |                                                      |   
    |      |     |       WAN IP: 10.25.25.2     |         |                                                      |   
    |      |     |                              |         |                                                      |   
    |      |     |      +--------------+        |         |                                  +----------------+  |   
    |      |     |      |   my peer    |        |         |                                  |                |  |   
    |      |     |      |              |        |         |                                  |                |  |   
    |      |     |      |  192.168.1.2 |4132--------4132 -----9165                           |   other peer   |  |   
    |      |     |      |              |        |         |extern: 113.30.25.32:9165    4132 |                |  |   
    |      |     |      +--------------+        |         |--------------------------------- |                |  |   
    |      |     +------------------------------+         |                                  |                |  |   
    |      +----------------------------------------------+                                  +----------------+  |   
    |                                                                                                            |   
    +------------------------------------------------------------------------------------------------------------+   

Here is my network topology.
So I can not receive ChallengeResponse-A

@ljedrz
Copy link
Collaborator

ljedrz commented Dec 19, 2022

This check is currently disabled, so closing the issue.

@ljedrz ljedrz closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network A network-related issue testnet2
Projects
None yet
Development

No branches or pull requests

3 participants