Error when connecting to PKI enabled server

[hamiltoncj]

When I attempt to add a repository to a server that uses PKI authentication. I click on the "Add..." button and give it a name and url, then next to Authentication I click on Add to select my certificate token then click on "OK", I get this error message:

type object 'QgsAuthManager' has no attribute 'instance'

[hamiltoncj]

This error occurs in network_manager.py and probably at line 56 with these lines of code:

            QgsAuthManager.instance().updateNetworkRequest(
                request, self._auth_cfg
            )

I have been using QgsNetworkContentFetcher for these calls and it works beautifully because auth_cfg is integrated into it. The only problem is that it requires QGIS 3.10 and above. QgsBlockingNetworkRequest also works well and works with QGIS 3.6 and above. I made some attempt to fix the problem, but am not sure how to do it with a QNetworkRequest.

[zacharlie]

I also got the type object 'QgsAuthManager' has no attribute 'instance' error when trying to use the authentication manager.

@ricardogsilva pointed out to me that QgsApplication.authManager() is the correct way to instantiate the authentication manager.

I had a look and it seems the API changed. I have a draft pull request #170 which seemed to fix this for me but I think needs further testing.

[hamiltoncj]

I have already tried this as a fix, but it is not sufficient. PKI authentication is quite complex and I tried at one time to implement it with QNetworkRequest, but there is much more to it then this. I never really got it working. The QGIS team put a lot of work into QgsNetworkContentFetcher and QgsBlockingNetworkRequest and made sure they work with PKI. I don't recommend that you use QNetworkRequest because it is going to continually cause problems. I recommend that you switch to one of these QGIS integrated calls.

[hamiltoncj]

I have one other comment which is that QgsApplication.authManager() fixed the error I first reported, but it does not fix the PKI authentication. What fails now is the SSL handshake.

[hamiltoncj]

@zacharlie
I have been doing some more testing, using

QgsApplication.authManager().updateNetworkRequest(
request, self._auth_cfg
)

fixes this main problem and allows the directory of resources to be read; however, it appears that that the auth_cfg id is not being used when the actual resource is requested which results in an SSL error to download the resource.

You can see this as follows:

In the file basy.py around line 128 in fetch_metadata, NetworkManager is called

network_manager = NetworkManager(self.metadata_url, self.auth_cfg)

but when the resource is requested it is without auth_cfg (remote_zip_handler.py line 49)

network_manager = NetworkManager(self.file_url(collection_path)) # No auth_cfg

Also in repository_manager.py line 92

downloader = NetworkManager(self.Directory_URL) # No auth_cfg