-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: new check for image alt text #1651
Comments
Hi @Eric-Arellano, is this issue similar to this one where simply alt text is to be added, or is a new check to be implemented? |
Thanks for offering, @shraddha-aangiras! That would be an enormous help. Alt text is crucial for accessibility. This issue is about adding a generic check, whereas #1659 is fixing all the current violations we have. This issue is an infra task, whereas 1659 is a content task that the technical writers can help with. Here are some thoughts on how you could add this check:
How does this sound @shraddha-aangiras? Would you like me to assign you? |
Thank you so very much for the comprehensive breakdown @Eric-Arellano! It helped me understand how to implement this and also how the checks like these work. I would love to work on this, please assign this to me! Thanks again! |
Great! Let me know if you have questions, and also feel free to open a draft PR with |
@Eric-Arellano Thank you so much! |
We're going to reuse this logic in #1651, so it's helpful to have in a common helper file.
We're going to reuse this logic in Qiskit#1651, so it's helpful to have in a common helper file.
This pull request adds an image checker to ensure all images have an alt text defined, which is crucial for accessibility, and that we don't have any `<img>` HTML tag. The output of the check shows the file name that contains invalid images and the images' names. Ex: ``` Error in file 'docs/guides/custom-transpiler-pass.ipynb': - The image '/images/guides/custom-transpiler-pass/DAG.png' does not have alt text. Invalid images found 💔 See https://github.com/Qiskit/documentation#images for instructions. ``` The PR builds on the work done by @shraddha-aangiras on #1800. I have made some changes to simplify the code and incorporated @Eric-Arellano's feedback. Thank you both for the work you've done! Closes #1651 --------- Co-authored-by: Eric Arellano <[email protected]> Co-authored-by: Shraddha Aangiras <[email protected]>
All images need to have alt="some alt text" , like in the following example
The text was updated successfully, but these errors were encountered: