-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with large and inaccessible Qiskit GIF #2533
Comments
@abbycross and I discussed that we should remove this explanatory content, as Jake suggested. That is acceptable given the current strategy of the docs that we are not focused on introductory explanation of theory anymore. Once Abby applies that change, the infra team will help backport the change to historical API docs to fix all historical violations. |
Fwiw, removing the GIF from the pages won't change the repo size. It'll change the size of a checkout on disk (which I suppose is still useful), but not the size needed to clone - the blob's already been included in the history, so removing it won't change things now. If repo size is a concern, the biggest thing would probably be to not have checked rendered / generated pages into this repo - at the moment, you're paying the weight of 20-odd complete current renders, plus every single historical render that's every been checked in, and checking out a new ref means traversing a whole load of that history rewriting those files. The GIF itself has never been changed since its inclusion, so it's 2.7MB of dead weight, but it's just a single blob - it's only stored once in the repo data (though a checkout will make many temporary copies of that blob, but that's disk-bound, not network-bound work). |
Ack. Although #2539 & shallow clones mean removing this will help with initial clones.
Yes, but a large blob duplicated on every version. #2525 has an idea to de-duplicate duplicate images, although it's set to low priority. -- All that being said, the biggest motivation is accessibility and GA compliance. |
It's not duplicated in the If the duplication on disk of a checkout is a problem, then the root cause is likely. more that all the generated files for each build are stored in the "human working" repo, rather than one specific file. Would something like a Footnotes
|
Of course, my system would still need an entire history re-write to remove the existing cost of the initial clone, since those files have already been committed. And yeah, I'm still 100% in favour of getting rid of the GIF from the docs. Mostly just commenting on the points about its effect on the |
We need to apply Qiskit/qiskit#13616 to all historical versions of Qiskit, as well. We do that by modifying the Box artifact if the version is no longer actively maintained, else backporting it in the Qiskit repo. |
See https://github.com/Qiskit/documentation/blob/main/public/images/api/qiskit/depth.gif and its usage:
documentation/docs/api/qiskit/qiskit.circuit.QuantumCircuit.mdx
Lines 3490 to 3500 in be6687b
Issues with GIFs:
Ideas for workarounds:
Migrating the file from GIF to AVIF only reduced the image from 2.7MB to 2.3MB, and it corrupted the GIF.
Note that this GIF is in our historical API docs. We should probably rewrite them to not have the image so that those pages load quicker & our repo size is smaller.
--
Response from Jake L in Slack, Dec 27
The text was updated successfully, but these errors were encountered: