Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Sampler V2 #211

Closed
nonhermitian opened this issue May 5, 2024 · 2 comments
Closed

Move to Sampler V2 #211

nonhermitian opened this issue May 5, 2024 · 2 comments
Assignees

Comments

@nonhermitian
Copy link
Collaborator

backend.run() is being removed in favor of the Sampler interface. We will therefore need to move to that

@nonhermitian
Copy link
Collaborator Author

Looking into this, I see that things are not so great. Namely unlike backend.run doing this will require having the runtime as a dependency if passing a backend instance is still supported (which it should be).

Rather than passing a backend and a Batch or Session, I am leaning towards just allowing a Batch or Session to be passed in place of the current backend object and we can just add a Sampler job to the given container, if any, or do normal "job" mode if a backend is passed. I think I will return the job instance in all cases for reference.

@nonhermitian
Copy link
Collaborator Author

Closed by #216 but will be refactored in a follow-up since I think there is a better way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant