Update Qiskit to v1.3.0 #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesus-talavera-ibm
requested review from
cbjuan,
d-kremer,
victor-villar and
y4izus
as code owners
| @@ -93,7 +94,7 @@ def __init__( | |||
| } | |||
|
|
|||
| def get_versions(self): | |||
| url = f"{self.url}/version" | |||
| url = f"{self.base_url}/version" | |||
There was a problem hiding this comment.
Why do we need this change? Because it is only in the top level api?
There was a problem hiding this comment.
Yes, /version endpoint is only available at root level.
It was removed in the rest of endpoints to avoid redundancy, but since we didn't use it until now, client was not affected
victor-villar
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🔧 Fixes #143
Details and comments