Only apply MCMT plugin on MCMTGate
#13596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
Changelog: Bugfix
Cryoris
requested review from
alexanderivrii,
ShellyGarion and
a team
as code owners
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 12465784214Details
💛 - Coveralls |
alexanderivrii
approved these changes
Dec 26, 2024
Comment on lines
+295
to
+296
| mcmt = MCMT(gate=gate, num_ctrl_qubits=1, num_target_qubits=1) | ||
| circuit.append(mcmt, circuit.qubits) # append the MCMT circuit as gate called "MCMT" |
There was a problem hiding this comment.
A bit off-topic. Here we are appending the quantum circuit mcmt to the quantum circuit circuit, yet the docstring for append states instruction: Operation | CircuitInstruction. The code does work, since a QuantumCircuit defines a to_instruction method, which append tries to use when the instruction is not of type Operation. Would it be slightly cleaner to change to circuit.append(mcmt.to_instruction(), ...), or should we change the typehint for the append method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13563, by enabling the high-level synthesis plugins of MCMT only for the
MCMTGate, not any gate called"mcmt".Details and comments
While we often let it be the user's responsibility to be mindful with gate names, this is a special case as we provide a circuit called
"mcmt". This can cause innocent-looking code to break, so we should add this check at least until theMCMTcircuit is removed 🙂