Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect hypothesis use and suggest marking as thread-unsafe #20

Open
ngoldbaum opened this issue Nov 19, 2024 · 4 comments
Open

Autodetect hypothesis use and suggest marking as thread-unsafe #20

ngoldbaum opened this issue Nov 19, 2024 · 4 comments
Assignees

Comments

@ngoldbaum
Copy link
Contributor

In the vein of #17.

See Quansight-Labs/free-threaded-compatibility#116

@lysnikolaou
Copy link
Member

I'm a bit confused. Do you mean that pytest-run-parallel should suggest marking it as thread-unsafe by outputting a message somewhere or that it should do it?

@rgommers
Copy link
Member

No message I think, just apply the thread_unsafe marker so any tests using hypothesis are not run in parallel, since that's just as unsafe as, for example, pytest.warns it looks like.

@lysnikolaou
Copy link
Member

Got it. I just wanted to make sure we're aligned on that because of the wording "and suggest marking as thread-unsafe" in the issue title.

@ngoldbaum
Copy link
Contributor Author

Sorry, that was me misunderstanding how pytest-run-parallel handles pytest.warns.

@lysnikolaou lysnikolaou self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants