Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lecture_comparison] Check instances of code not being compiled #15

Closed
sayaikegawa opened this issue Jan 22, 2021 · 7 comments
Closed
Assignees

Comments

@sayaikegawa
Copy link
Collaborator

sayaikegawa commented Jan 22, 2021

This is an issue that a code is not compiled.

Here is an example:
Left:RST Right:MyST```
Screen Shot 2021-01-22 at 5 44 43 pm

This occurs in:
16
32
33
35
39
40
41
42
43

cc: @mmcky

@sayaikegawa
Copy link
Collaborator Author

sayaikegawa commented Jan 28, 2021

After fixing this issue, Value Error and Name Error in lecture No. 39, 42 and 43 should be checked because those errors which happen in 41's RST do not occur in the MyST output.

@mmcky mmcky changed the title [lecture_comparison]code_not_compiled [lecture_comparison] Check instances of code not being compiled Apr 15, 2021
@mmcky
Copy link
Contributor

mmcky commented Apr 19, 2021

@mmcky
Copy link
Contributor

mmcky commented Apr 19, 2021

I suspect many of these are due to no code from files which is now up and running in PR #4

For example, it looks like lucas_model is running and executing the code.

@shlff would you be able to run through the links above and check against the latest build in PR #4 which includes the code from files?

@shlff
Copy link
Member

shlff commented Apr 19, 2021

Thanks @mmcky and @sayaikegawa .

Hi @mmcky , I checked the corresponding code and output in the latest build in PR #4 (https://607d30a416bfbb1ec11723fc--wonderful-lalande-528d1c.netlify.app/intro.html) and I find the issue still exists in:

@mmcky
Copy link
Contributor

mmcky commented Apr 20, 2021

thanks @shlff -- if you have time can you dig into each of these lectures to try and figure out why they aren't executing.

To get the same software environment you can use the environment.yml file to create a conda environment

conda env create -f environment.yml
conda activate quantecon

and then you can look in the _build/jupyter_executed to get some further details (or _build/html/reports)

@mmcky
Copy link
Contributor

mmcky commented Apr 20, 2021

@shlff I know the reason -- I need to migrate file to load

@mmcky
Copy link
Contributor

mmcky commented Apr 20, 2021

For matsuyama and black_litterman I have opened #28 as this is a widget issue.

@mmcky mmcky closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants