Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply() in custom script does not have verbose log output #505

Open
Cynthia7979 opened this issue Oct 28, 2024 · 2 comments
Open

apply() in custom script does not have verbose log output #505

Cynthia7979 opened this issue Oct 28, 2024 · 2 comments

Comments

@Cynthia7979
Copy link

Describe the bug
The apply(ChunkData data) function does not print an error trace to the log file when its execution fails.

To Reproduce

  1. Go to 'Tools > Change fields'
  2. Click on 'Script'
  3. Enter any script that would produce an error into the function body of apply. Simplest example: a
  4. Click 'OK'
  5. Click 'OK' in the confirmation dialog
  6. View the log file
  7. Observe the absence of error trace in the log

Expected behavior
If the apply method produces any error while being executed, then a trace message for the exception should be printed to the log file in a similar fashion as how the "Custom" field and the before and after methods had done it.

Screenshots and other files
mcaselector.log

Environment:

  • OS: Windows 10
  • Java version: 21.0.2
  • Version of MCA Selector: 2.4.2
@arvitus
Copy link
Contributor

arvitus commented Nov 12, 2024

First, I though this was an error on your side, but then I looked at the code and realized you're actually absolulety right. While it does print that there was an error, it does not print what exactly the error was.

Unfortunately, we can't really do anything about it until Querz is back and can merge the open PRs :(

@Cynthia7979
Copy link
Author

Oh I see, I didn't know Querz's on a break. Thanks for taking a look anyway. I guess we'll wait now for the PRs to be merged :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants