Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with PHP 7.3 due to dependency of sunra/php-simple-html-dom-parser #36

Closed
obj63mc opened this issue Dec 20, 2018 · 1 comment
Closed

Not compatible with PHP 7.3 due to dependency of sunra/php-simple-html-dom-parser #36

obj63mc opened this issue Dec 20, 2018 · 1 comment

Comments

@obj63mc
Copy link
Contributor

obj63mc commented Dec 20, 2018

Currently the composer module sunra/php-simple-html-dom-parser does not support php 7.3 sunra/php-simple-html-dom-parser#64

It does not appear that module is supported anymore so wondering if we might have a way to work around this issue or have your module run a fork of this package.
obj63mc added a commit to obj63mc/silverstripe-seo that referenced this issue Jan 8, 2019
@obj63mc
Update for PHPSimple HTMLDomParser
ba88c56 
This fixes the compatibility issue with PHP 7.3 issue sunra/php-simple-html-dom-parser#64 and Quinn-Interactive#36
@obj63mc obj63mc mentioned this issue Jan 8, 2019
Merged
zanderwar added a commit that referenced this issue Jan 19, 2019
@zanderwar
Merge pull request #37 from obj63mc/master
5e577c2 
Resolve issue #36 - php 7.3 compatiblity
@zanderwar
Copy link
Contributor

Merged your PR, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obj63mc @zanderwar