Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2-factor authentication. #46

Open
volkb opened this issue Feb 7, 2020 · 7 comments
Open

add 2-factor authentication. #46

volkb opened this issue Feb 7, 2020 · 7 comments
Labels
enhancement New feature or request security

Comments

@volkb
Copy link

volkb commented Feb 7, 2020

After a given period of time a user should be required to double authenticate their login using either SMS or email. A user should also have to do this if they are logging into the platform from a new IP address for the first time.

@volkb volkb added enhancement New feature or request security labels Feb 7, 2020
@bnidevs
Copy link
Contributor

bnidevs commented Jul 27, 2020

Do you want to use google cloud for this or something else

@volkb
Copy link
Author

volkb commented Jul 27, 2020

It doesn't have to be. Essentially we would just add a 'last logged in' and 'ip' field to the users section of the data model. Then on login, we would just do some math on that field to see if the user has been logged in recently (lets say 30 days) and/or they are on a new IP than ones the system recognizes, and if not, a code is sent to their email or phone for them to 2 factor authenticate with.

@wave100
Copy link
Member

wave100 commented Jul 27, 2020 via email

@HonakerM
Copy link
Member

Going off of what Rish said I would use our current sendgrid implementation. There are more pressing things for this semester and I don't want to over complicate something that could be done simply for the time being. In the future we could look into sms.

@volkb
Copy link
Author

volkb commented Jul 27, 2020 via email

@HonakerM
Copy link
Member

@volkb if we implemented SMS it would not be through an SMS gateway. There are to many issues with it and I have also had messages take days to send. We would use something like Azure Bot or AWS Pinpoint. Like I said in my previous posts this is not a priority. Getting our site mobile friendly is much more important at this moment.

@volkb
Copy link
Author

volkb commented Jul 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

No branches or pull requests

4 participants