Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move token layout panel to its own tab in edit token dialogue #5097

Open
Tracked by #5096
bubblobill opened this issue Dec 8, 2024 · 0 comments
Open
Tracked by #5096

Move token layout panel to its own tab in edit token dialogue #5097

bubblobill opened this issue Dec 8, 2024 · 0 comments
Assignees
Labels
in progress Issue is actively being worked on

Comments

@bubblobill
Copy link
Collaborator

bubblobill commented Dec 8, 2024

EditTokenDialog

  1. Added checkboxes for Flip-X, Y, and Iso
  2. Incorporated Unique Light Sources text area
  3. Moved token layout panel to it's own tab

Four additional classes:

  1. SpinnerSliderPaired ties a JSpinner and a JSlider together with some bells and whistles
  2. TokenLayoutRenderPanel contains the paint method and handles mouse events
  3. TokenLayoutRenderPanelHelper handles the initialisation code for control elements and a bunch of methods for creating and drawing various elements and onscreen guides
  4. MathUtils a generic utils class for doing math stuff. Math operations in other classes should probably be moved to it too.

GraphicsUtil added method createGridShape() for generating a grid shape consistently.

ImageUtil added a bunch of methods for operations to reduce ZoneRenderer code duplication:

  1. getIsoFigureHeightOffset
  2. getTokenImage - returns token image or table image if iso figure
  3. flipCartesian - for flipped token images
  4. flipIsometric - for flipped token images
  5. getRenderingHintsQuality - a single source for a number of higher quality rendering hints
  6. rotateImage - rotates an image
  7. getScaledTokenImage - accounts for ZoneRenderer zoom level, token sizeScale, scaleX, scaleY and footprint size and scale
  8. getTokenRenderImage - does most of these in appropriate order to maintain best image quality
@bubblobill bubblobill changed the title Move token layout panel to its own tab in the Edit Token dialog. Move token layout panel to its own tab, add token props and macro functions. Dec 9, 2024
@bubblobill bubblobill changed the title Move token layout panel to its own tab, add token props and macro functions. Move token layout panel to its own tab in edit token dialogue Dec 11, 2024
@bubblobill bubblobill self-assigned this Dec 16, 2024
@bubblobill bubblobill added the in progress Issue is actively being worked on label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Issue is actively being worked on
Projects
None yet
Development

No branches or pull requests

1 participant