Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK V2 Integration #8

Open
kochie opened this issue May 30, 2021 · 0 comments
Open

CDK V2 Integration #8

kochie opened this issue May 30, 2021 · 0 comments

Comments

@kochie
Copy link

kochie commented May 30, 2021

Hi @RafalWilinski,

I've been using the construct for a while now and it's great! However with CDK v2 coming out soon the current package won't install/work due to peer dependency issues and the new way the cdk has been structured.

I've taken the liberty of creating a version of your code that works with CDK v2. Link Here, I've also used the opportunity to base the project off projen the preferred way to make constructs now from what I can see.

Anyways I'd be keen to setup a PR into your project but it would be a breaking change to the version you already have. Might also be a good opportunity to see if we can get your code into the CDK as a first class construct.

Anyways let me know what you think, I'm also happy to keep it as a separate package if you don't have time to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant