Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Lidarr - Consider moving to Tidal-DL-NG? #289

Open
mrnoisytiger opened this issue Jul 28, 2024 · 4 comments
Open

[FEATURE] - Lidarr - Consider moving to Tidal-DL-NG? #289

mrnoisytiger opened this issue Jul 28, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on

Comments

@mrnoisytiger
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The existing Tidal-DL implementation unfortunately fails to grab "MAX" quality (i.e., high res greater than 16/44.1). Instead, the newer alternative, tidal-dl-ng is able to grab the files without having to go through too much hassle with the API keys.

Describe the solution you'd like
A clear and concise description of what you want to happen.

It would be great to be have an implementation of tidal-dl-ng, which from my testing, works similarly to tidal-dl over the CLI.

@mrnoisytiger mrnoisytiger added the enhancement New feature or request label Jul 28, 2024
@RandomNinjaAtk
Copy link
Owner

RandomNinjaAtk commented Aug 19, 2024

FYI: the package is incompatible and won't install without some sort of workaround most likely, so this is dead in the water for now as I cannot investigate the viability of it because I cannot install it in the current environment.

Error for reference:

ERROR: Could not find a version that satisfies the requirement tidal-dl-ng (from versions: none)
ERROR: No matching distribution found for tidal-dl-ng

@RandomNinjaAtk RandomNinjaAtk added help wanted Extra attention is needed wontfix This will not be worked on labels Aug 19, 2024
@samhaswon
Copy link

It looks like the Python version for Alpine:latest is 3.12.5-r0 which is incompatible with tidal-dl-ng. According to its requirements, it needs python = ">=3.10,<3.12", likely due to upstream dependencies. You can work around this by switching to the v3.19 branch of Alpine, given that doesn't break anything else. It can be done like so:

echo "https://dl-cdn.alpinelinux.org/alpine/v3.19/main" >> /etc/apk/repositories
echo "https://dl-cdn.alpinelinux.org/alpine/v3.19/community" >> /etc/apk/repositories

I then removed the newer Python version packages:

apk del python3 python3-dev

I'm not sure if you have to add specific versions from there, but I'll put that in here anyway.

apk add python3=3.11.9-r0 python3-dev=3.11.9-r0

And install the package:

pip install tidal-dl-ng --break-system-packages

Now, I only tested this on a regular Alpine image, so it might break on linuxserver's image for some random reason.

@ChilliGeologist
Copy link

A recent commit seems to be allowing tidal-dl-ng to work on Python 3.12.

@ChilliGeologist
Copy link

It looks like the commit I mentioned above is now part of the main release as of v0.23.5. @RandomNinjaAtk I've managed to install tidal-dl-ng into a Lidarr docker container without any issues. I don't really have a good understanding of Python but the only thing I had to do was run the following commands:

python3 -m venv /path/to/venv
. /path/to/venv/bin/activate
pip install --upgrade tidal-dl-ng

I'm wondering if this is enough progress for this to be investigated further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants