Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository File Structure #1

Open
enigma9o7 opened this issue Mar 16, 2021 · 2 comments
Open

Repository File Structure #1

enigma9o7 opened this issue Mar 16, 2021 · 2 comments

Comments

@enigma9o7
Copy link

enigma9o7 commented Mar 16, 2021

Just some suggestions.

First add a README.md. It's unclear what is recommended way to use it.

My assumption was first that it was going to be repo that r96 model packs are based on, and people able to clone (and later pull) to keep current rolling version.

Then a subdir appeared with bunch of old versions. Not something I needed to git pull. Suggestion: Either move those to releases section (ideal, and will be permanent url), or if you really want to keep them in the repository, make another branch for them, so can clone --single branch and not get the entire back catalog, and less likely for them to change if in a branch nobody is using for development.

Second, please don't use spaces in foldernames in a git repo. It makes it inconvenient to type, have to use quotes or escape characters, etc, and can lead to potential problems unless you're careful. Its far easier and more conventional to not use spaces. So if you do move to another branch, and do use a subfolder, just call it archived or something. But better just to add to releases, but if you must keep in repo for some reason and use another branch, call the branch archived and dont use subdirs in it at all.

@enigma9o7
Copy link
Author

So still no README.

Still copies of archived releases in main branch. There is no need for that archived version folder in the repository and just wasting everyones disk space, bandwidth, and time.

Now it appears the Render96 folder has been removed!! So if a user pulls, it will disappear. Models gone.

And then new folders. If one of them is the render96 folder renamed, sure pulling will rename it for users, but anything linking to it (like builds of sm64) won't know the folder was renamed. I just saw this now and haven't taken the time to try to figure out what's going on with the four folders, but quick glance looks like LOTS of duplicated files. This makes no sense. The only reason to put four versions in one branch would be if they have lots of shared files, one is the main one and the others link from there with only minor difference.

The way this is structured it appears to be designed without any consideration to space, bandwidth, development, or usage.

@Nonethousand
Copy link

what

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants