Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "unregisterCallbacks" method is not working #26

Open
henczi opened this issue Jan 30, 2020 · 4 comments
Open

The "unregisterCallbacks" method is not working #26

henczi opened this issue Jan 30, 2020 · 4 comments

Comments

@henczi
Copy link

henczi commented Jan 30, 2020

The registerCallbacks and the unregisterCallbacks methods always create a new function for the handlers, therefore the unregistration process will not work (because the comparison in the HubConnection's off method is reference-based).

https://github.com/dotnet/aspnetcore/blob/master/src/SignalR/clients/ts/signalr/src/HubConnection.ts#L460

Related PR: #22

@RicoSuter
Copy link
Owner

I agree, this cannot work.

/cc @beorosz

@beorosz
Copy link
Contributor

beorosz commented Feb 14, 2020 via email

@RicoSuter
Copy link
Owner

Probably we need to change the way we register/unregister... (but we need to ensure that this still works correctly on the implementation).

@beorosz
Copy link
Contributor

beorosz commented Feb 14, 2020

Okay, I started to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants