-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto tag does not appear to be working, probably user error #29
Comments
Here is my metadata.rb... just incase
and my VERSION file is in .gitignore |
When this happens to us, it usually means the CI job can’t push tags. Do you have the output of thor version bumping in the CI run? |
You are correct, the CI didn't have write, but it does now, which got me further. However now I am having another problem, my Jenkins server get's into a build loop.
I am not sure how to get around this.... |
@ivey Any thoughts ? Do u guys use commit hooks w/ this ? |
I think I am missing something. Why is Jenkins committing? |
Jenkins should just be tagging the commit that it has just built, not creating a new commit. |
So I am tagging a commit, and pushing to Bitbucket, which in turn sends a On Fri, Nov 22, 2013 at 7:37 PM, Josiah Kiehl [email protected]:
|
Ah ok. One fix would be to have Jenkins poll the repo for changes rather than have BitBucket initiate the build. |
Is that really the solution ? My team generally shy's away from git On Sun, Nov 24, 2013 at 3:32 AM, Josiah Kiehl [email protected]:
|
At this point the problem is outside the domain of scmversion, so I don't know exactly what the best fix would be. Given your builds trigger off tag pushes, and scmversion does versioning via tag pushes, you might be stuck trying to have BitBucket trigger builds. |
We could check to see if the current version matches the current tag, and not change the version, since there's no changes. Would want it as an option but that might be a good thing. PR welcome if we don't get around to doing that soon. |
So I am not sure I am doing this right. I am especially not clear on what the following means.
As I understand it, I should be able to simply add #patch #major, or #minor in the commit message and thor-scmversion will handle the rest, but that doesnt seem to be the case for me....
So here is my setup. First off I have a tag on my repo ( 0.1.35 ). In my Thorfile I have a release task which you can see below:
When I pushed 0.1.35 everything seemed to work great, the first time.. However now it does not seem to be incrementing the versions like I expected. Example below:
You will not that I made a few commits with the #patch key in the commit message. On each of these commits my CI re-ran my release task. The problem is on both of these tests I berks upload ended up uploading 0.1.35. I was under the impression that it should have uploaded 0.1.36 and 0.1.37.
The text was updated successfully, but these errors were encountered: