Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Thorfile in a directory other than the root of a gir repo. #31

Open
rteabeault opened this issue Feb 24, 2014 · 0 comments
Open

Support Thorfile in a directory other than the root of a gir repo. #31

rteabeault opened this issue Feb 24, 2014 · 0 comments

Comments

@rteabeault
Copy link

We are using a pattern of placing the cookbook within the repo of the application it deploys. We would like to keep the Thorfile with the cookbook. Currently in this configuration thor-scmversion can not find the .git dir and defaults to perforce. Instead I propose that it looks up the directory hierarchy for a .git dir. Is this something that would be welcomed as a PR?
rteabeault pushed a commit to RallySoftware-cookbooks/thor-scmversion that referenced this issue Feb 24, 2014
Issue RiotGamesMinions#31 - Lookup the dir hierarchy for .git dir
f6120e0
rteabeault pushed a commit to RallySoftware-cookbooks/thor-scmversion that referenced this issue Feb 24, 2014
Issue RiotGamesMinions#31 - Lookup the dir hierarchy for .git dir
56337dd
rteabeault pushed a commit to RallySoftware-cookbooks/thor-scmversion that referenced this issue Feb 24, 2014
Issue RiotGamesMinions#31 - Lookup the dir hierarchy for .git dir
35598e0
capoferro added a commit that referenced this issue May 29, 2014
@capoferro
Merge pull request #34 from RallySoftware-cookbooks/issue-31
2bc9b38 
Issue #31 - Look up the dir hierarchy for .git dir
ivey added a commit that referenced this issue Jun 25, 2014
@ivey
Revert "Issue #31 - Look up the dir hierarchy for .git dir"
792381a
ivey added a commit that referenced this issue Jun 25, 2014
@ivey
Merge pull request #36 from RiotGames/revert-34-issue-31
168f1e3 
Revert "Issue #31 - Look up the dir hierarchy for .git dir"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rteabeault