Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Separate ROS2 dependencies from Python dependencies #387

Open
4 tasks
coderabbitai bot opened this issue Jan 25, 2025 · 2 comments
Open
4 tasks

refactor: Separate ROS2 dependencies from Python dependencies #387

coderabbitai bot opened this issue Jan 25, 2025 · 2 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2025

Background

Currently, some Python packages used in the codebase (e.g., tf_transformations) are installed via rosdep. As part of the transition from a ROS2 package to a pure Python package, we need to properly declare these dependencies in pyproject.toml.

Tasks

  • Identify all Python packages currently installed via rosdep
  • Add these packages to pyproject.toml with appropriate version constraints
  • Update documentation to reflect the changes in dependency management
  • Test installation outside of ROS workspace

References

Notes

This issue consolidates all ROS2 dependency-related comments from PR #386 to track the separation of ROS2 dependencies from Python dependencies.

@maciejmajek
Copy link
Member

Effort started under #411. Additional things to be done in the future.

@maciejmajek
Copy link
Member

Dockerfile courtesy of @boczekbartek for testing rosless setups.

FROM ubuntu:24.04 
ENV DEBIAN_FRONTEND=noninteractive

# Install dependencies
RUN apt-get update && apt-get install -y \
    python3 \
    python3-pip \
    git \
    wget \
    curl

# Install Poetry
RUN curl -sSL https://install.python-poetry.org/ | python3 - --version 1.8.4
ENV PATH="/root/.local/bin:$PATH"

# Clone and setup RAI
WORKDIR /rai
RUN git clone --branch development https://github.com/RobotecAI/rai.git .

USER root 
# Install Python dependencies with Poetry
RUN poetry install --with nomad,openset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant