Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up duplicate dependencies in main pyproject.toml #412

Open
5 tasks
coderabbitai bot opened this issue Feb 7, 2025 · 0 comments
Open
5 tasks

Clean up duplicate dependencies in main pyproject.toml #412

coderabbitai bot opened this issue Feb 7, 2025 · 0 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2025

Background

The main pyproject.toml contains dependencies that are duplicated in nested pyproject.toml files of the sub-packages (rai_core, rai_asr, rai_tts). These dependencies need to be cleaned up and properly organized before the release.

Examples

  • lark package is only required by ROS2 and should be moved to the appropriate sub-package
  • Other dependencies need to be reviewed and moved to their respective sub-packages where they are actually used

Action Items

  • Review all dependencies in main pyproject.toml
  • Identify which dependencies belong to which sub-package
  • Move dependencies to appropriate sub-package pyproject.toml files
  • Remove redundant dependencies from main pyproject.toml
  • Verify that all packages still build and work correctly after the cleanup

This cleanup is required before the release to ensure proper dependency management.

Related PR discussion: #411 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant