Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15.32.1. Creating the View missing code #202

Open
pearcej opened this issue Nov 15, 2021 · 4 comments
Open

15.32.1. Creating the View missing code #202

pearcej opened this issue Nov 15, 2021 · 4 comments

Comments

@pearcej
Copy link
Contributor

pearcej commented Nov 15, 2021

The active code window in 15.32.1 just says code

image

@Mrjwm
Copy link

Mrjwm commented Aug 29, 2024

+1
15.32.1 Creating the View, 15.32.2 Creating the Model, and 15.32.3 Creating the Controller are all missing the code. This code is expected because the last sentence of 15.32 is, "Let’s walk through the code development." Additionally, this chapter comes before the 'Classes' chapter so the code is necessary (preferably with the aforementioned supplemental walk-through) to avoid skipping ahead.

@bnmnetp
Copy link
Member

bnmnetp commented Aug 29, 2024

How odd... I don't think the original author of this chapter ever finished this lesson before he retired...

I'm not really sure what to do. My first inclination would be to eliminate the reference to an improved implementation in the previous lesson, and just remove this lesson from the book.

I haven't looked at tkinter in years! And I definitely don't have the time to try to write this chapter.

@Mrjwm
Copy link

Mrjwm commented Aug 30, 2024

The rest of the chapter teaches TK very well, so I think omitting these sections entirely would suffice. But, FWIW, I think the (intended) value of these sections are in the implementation of the Model-View-Controller design pattern and breaking the code into modules; a very important lesson that isn't covered (beyond an introduction) anywhere else in the book.

@bnmnetp
Copy link
Member

bnmnetp commented Aug 30, 2024

Sure, I would welcome a PR from anyone who had the time to fill out that section. I'm just saying that I do not have that time with everything else I have to do to keep Runestone Academy up and running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants