-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization suggestions #617
Comments
Could you please share some more details on your proposed optimization? I.e. what is the problem you want to solve? And how do you want to solve it, in more detail? You can find our contributing guideline here: https://github.com/SAP/ui5-tooling/blob/master/CONTRIBUTING.md#-contributing-code |
Could you please share some more details about your thoughts on 1. and 2.? |
Edit RandomByte: Layout changes for readability |
Comments are generally removed when bundling, with only few exceptions such as copyright statements being preserved for legal reasons. See for example: https://ui5.sap.com/resources/sap-ui-core.js You should be able to see the same behavior when checking the Component-preload.js or library-preload.js files in the build result of your projects. Can you share more details where you see a large size of comments in bundles created by UI5 Tooling?
This might be a reasonable enhancement in the future. It could be possible to filter localization files based on a configured set of languages. But this needs further clarification. We should check whether this can be solved in a custom task first.
This might be the same requirement as discussed in #731 |
This issue has been automatically marked as stale because it has been open for 60 days with no activity. It will be closed in 10 days if no further activity occurs. |
The text was updated successfully, but these errors were encountered: