Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize embedding models #21

Open
tiadams opened this issue Sep 4, 2024 · 1 comment
Open

Generalize embedding models #21

tiadams opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
refactoring Code that needs to be rewritten, without changing functionalities
Milestone

Comments

@tiadams
Copy link
Member

tiadams commented Sep 4, 2024

Should be a single class (e.g. SentenceEmbedder) and will dynamically load the correct model based on the model name. Could be achieved as a wrapper class.

@tiadams tiadams added the refactoring Code that needs to be rewritten, without changing functionalities label Sep 4, 2024
@tiadams tiadams self-assigned this Oct 21, 2024
@tiadams
Copy link
Member Author

tiadams commented Oct 21, 2024

Relates to discussion #36

@tiadams tiadams added this to the v1.0.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code that needs to be rewritten, without changing functionalities
Projects
None yet
Development

No branches or pull requests

1 participant