New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

username, uid, and email settings description incorrect #65

Open

tbfisher opened this issue Jan 10, 2019 · 1 comment

Labels

bug

tbfisher commented Jan 10, 2019

in stanford_ssp_configuration_form() each of these settings state in the field description

"If the attribute is multivalued, the first value will be used."

however the getter functions

stanford_simplesamlphp_auth_get_authname()
stanford_simplesamlphp_auth_get_username()
stanford_simplesamlphp_auth_get_email()

assume it is an array and always fetch the first value

The text was updated successfully, but these errors were encountered:

Member

sherakama commented Jan 10, 2019 •

edited

Loading

Oh I see, each of those functions is assuming array and should validate the value in the attributes array for single vs multiple values.

https://github.com/SU-SWS/stanford_ssp/blob/7.x-2.x/modules/stanford_simplesamlphp_auth/stanford_simplesamlphp_auth.inc#L578

An is_scalar check is needed here I suppose.

sherakama added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment