Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Rename timelapse files #12

Open
nbelakovski opened this issue Jan 2, 2018 · 6 comments
Open

[Feature Request] Rename timelapse files #12

nbelakovski opened this issue Jan 2, 2018 · 6 comments

Comments

@nbelakovski
Copy link

Would be great to extend this to be able to rename timelapses. Any idea if that's easy to do? If you point me in the right direction maybe I could implement it myself.

@nbelakovski
Copy link
Author

nbelakovski commented Jan 3, 2018

I've dug around a little bit and came up with a little hack, which didn't really work. I added a symbolic link to the timelapse folder within the uploads folder. I can see the timelapse folder now within the octoprint filemanager ui, but not the timelapses themselves. It seems the filemanager is filtering on .gcode and .stl. Or rather, it's using apis from octoprint which do that kind of filtering. I guess a new filetype would need to be added to get this to work, or maybe it would be easier to just add a rename button to the file list in the timelapse tab.

@Salandora
Copy link
Owner

Add a button to the timelaps list.
That's much easier then trying to use a tool which is not designed to to that :-)

@nbelakovski
Copy link
Author

Not designed to do what?

@Salandora
Copy link
Owner

The file manager plugin was not designed to rename timelapse files.
It wasn't even supposed to have something to do with the timelapse files.

@nbelakovski
Copy link
Author

nbelakovski commented Mar 5, 2018 via email

@Salandora
Copy link
Owner

Yeah, that's right, but while developing I never had in mind to list anything else then the gcode/stl files, so everything is tailored to these files and apis.
This is why I said it was never supposed to support the timelapse files.

It surely could be added somehow but at the moment I'm not planning to implement anything like this, cause there are other things to come first, like a progress bar, some bugs that have appeared.

Well on the other hand I can understand your point, and should add it to the todo list for a future version and maybe it would be a good idea to restructure the code, so new files can be added more easily...

For now I will reopen it.

@Salandora Salandora reopened this Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants