Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a file fails to work on just-uploaded files #9

Open
robertwallace opened this issue Aug 25, 2017 · 4 comments
Open

Rename a file fails to work on just-uploaded files #9

robertwallace opened this issue Aug 25, 2017 · 4 comments

Comments

@robertwallace
Copy link

[ I am also using the Autoselect plugin. ]

It appears (or is a coincidence) that while Octoprint is actively calculating the print time on a newly uploaded (vi Slic3r's Send to Printer), and you're using FileManager to rename the file, the rename fails (without an error message or any other indicator) and the file is not renamed. After Octoprint posts the calculated print time, you can now go back and successfully rename the file.

Don't know if it's related, but if you rename a file and the name is already used by another file, the rename fails without error message or other indicator that the rename was not successful.

@robertwallace
Copy link
Author

... more specifically, if the screen refreshes behind the open File Manager rename dialog box, the change is ignored.

@Salandora
Copy link
Owner

Sadly this is true, I never came around to implement any error messages or other indicators, it's still on the todo list, but I lack the time for it.

The f the screen refreshes behind the open File Manager rename dialog box part sounds interesting, could you give an example how to reproduce it.

@robertwallace
Copy link
Author

It can be reliably reproduced by sending a file to the printer (via Prusa3D Slic3r's and Octoprint's API (with key). Note, again, that I'm also using the Autoselect plugin that will, when not printing, automatically select the just-uploaded file for printing (which starts Octoprint print time calculation.)

If you open File Manager and select a file (for renaming or whatever) before the print time calculations are posted (refreshing the Octoprint main screen) the file becomes unselected in File Manager. If you have the File Manager rename dialog box open at the time, your rename action is ignored.

You may also be able to reproduce it by getting Octoprint to refresh the window (without Autoselect installed) if you select a file from the uploaded file list, and then opening and selecting a file in File Manager before Octoprint finishes its print time calculations.

@Salandora
Copy link
Owner

Ahh I see, alright I can now think of why this happens.
Okay this could be a logic mistake, will take a look soon (If I can fit it into the weekend).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants