-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Internal change for the handling of external data #411
Comments
Hello 👋! Thank you very much for raising an issue 🙌! The maintainers will get back to you soon for discussion over the issue! 🚀Meanwhile you can also discuss about the project in our Discord Server 😀 |
Thank you for raising the issue @EasyG0ing1! It's a great improvement that can be implemented. |
I am going to work on this issue. Self-assigning myself 😃 |
Hello @SaptarshiSarkar12. Are you still working on this or can i try it? |
@Viereckig Thank you for your interest 😄. |
which Java SDK do i need to use? |
@Viereckig The latest LTS Release - JDK 21. |
Hey @SaptarshiSarkar12 have you ever encountered a problem when trying to run the program via Docker, as described in the README, where it fails to fetch packages? What i already tryed:
|
@Viereckig No, I haven't encountered such problems before. But, you can try running |
@Viereckig If that does not work for you, you can try changing your DNS to |
already did that... |
yeah i try that thanks |
@Viereckig Did that work? |
@SaptarshiSarkar12 sorry for the late response, I was very bussy the last few days! yeah it works now thanks |
@Viereckig It's fine 🙂. That's a good command to clear everything (caches, images, containers, etc.) from docker and helps in most cases of unexpected errors. |
@Viereckig Are you facing any issues? Have you started working on this? Please let me know 😄. |
@Viereckig has informed me that he is no longer going to work on this issue. |
Hello @SaptarshiSarkar12, recently a friend of mine reached out to you, that we would like to work on this issue as a team. So as you asked, I'm leaving a comment 🙂. |
@michalryn Hi Michał 👋! |
Hey, I am Kamil* small mistake:D leaving a comment too. |
@bdaf Hi Kamil 👋! |
As you asked, I also leave a comment :) |
Thank you @Rafalrrr159 😄! |
Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like.
This is not so much a feature request as it is an idea for internally restructuring Drifty so that it no longer relies on text files for things like URL lists, download queues, or even settings (where leveraging the Java Preferences class has limitations).
Instead, I am proposing that Drifty might be a good candidate to leverage a SQLite database for the storage and retrieval of dynamic data. The database / SQL method of storing and retrieving information is well understood and is relatively easy to implement.
A core class called something like DB could be created which contains all of the methods required to interact with external data. The database could have various tables, for example, a Jobs table which contains all of the relevant data for a download job in each record, or even a Log table which can store the various logs that Drifty generates. A Settings table could be used to store things like download folders, video quality preferences, or settings for GUI themes in the future. We could even keep a table for download statistics that keeps track of download metrics such as transfer speeds for past downloads etc. which then provides metrics that might be interesting in different contexts.
This change to Drifty could be developed non-invasively at first where it would just be a class that maintains the database file where the methods are defined then once they are in place and tested and working, it would then be a matter of converting those places throughout the program where it keeps information in flat files, and convert those methods to use the DB methods.
The database methods could even be presented to other developers as sort of an interface to external data where future development might be streamlined by the presence of the DB class, but this will be highly dependent on the nature of any future development.
Screenshots
No response
Additional information
This would also remove the GSON dependency because the use of Json files would be removed from the program all together.
The text was updated successfully, but these errors were encountered: