Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address disabled MyPy checks #570

Open
7 tasks
pp-mo opened this issue Nov 19, 2024 · 0 comments
Open
7 tasks

Address disabled MyPy checks #570

pp-mo opened this issue Nov 19, 2024 · 0 comments

Comments

@pp-mo
Copy link
Member

pp-mo commented Nov 19, 2024

QA checks which we expect later to review + possibly remove.

Controls are in pyproject.toml here

Summary of controls

The ultimate goal would be to have no 'ignores', but there are some files excluded.

We have set "strict=true", but some of the group of checks which that enables (see here) are temporarily turned off.
It is noted that setting 'strict=True' may be uncertaion does may change with future releases,
but we will probably decide that some exceptions will remain "permanent".

Extra non-default checks permanently enabled :

  • warn_unused_configs
  • warn_unreachable
  • enable_error_code = ["ignore-without-code", "truthy-bool"]

Remaining temporarily disabled checks :

  • disallow_any_generics
  • disallow_subclassing_any
  • disallow_untyped_calls
  • disallow_untyped_defs
  • disallow_incomplete_defs
  • check_untyped_defs
  • no_implicit_reexport
@pp-mo pp-mo changed the title TODOs for MyPy checking More fixes for MyPy checks Nov 20, 2024
@pp-mo pp-mo changed the title More fixes for MyPy checks Address disabled MyPy checks Nov 22, 2024
@pp-mo pp-mo mentioned this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant