Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace old GRIB1 loading unit tests in new-style loader #585

Open
Tracked by #56
pp-mo opened this issue Dec 16, 2024 · 0 comments
Open
Tracked by #56

replace old GRIB1 loading unit tests in new-style loader #585

pp-mo opened this issue Dec 16, 2024 · 0 comments

Comments

@pp-mo
Copy link
Member

pp-mo commented Dec 16, 2024

This is a bit of a late addition, but possibly there is some remaining value in the specific unit tests for GRIB1 loading
here , which we will want to somehow replicate or preserve ?
However when we retire the old GribMessage and _grib1_load_rules, all this will also cease to function since it is based on creating GribMessage objects and calling grib1_convert.

For example, there is a mock-ist test designed to check that an unrecognised PDT produces a suitable error, and similar nearby tests to ensure that we can handle various recognised and unrecognised phenomenon codings.
At least, we should check the units tests of our new code, to ensure we have covered the same issues.

Likewise, there are some complex mechanisms here to check that various types of 'timeRangeIndicator' produce various types of bounded coordinate.

Quite apart from replicating the behaviour testing here, we need to be in a position to retire a lot of the aging unittest-based code which supports this, soon if not now.

@pp-mo pp-mo changed the title transfer old grib1 loading unit tests to new GribMessage loader replace old grib1 loading unit testing in new GribMessage-based loader Dec 16, 2024
@pp-mo pp-mo changed the title replace old grib1 loading unit testing in new GribMessage-based loader replace old GRIB1 loading unit tests in new-style loader Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant