Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match old dist whitespace generation #506

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

danielpgross
Copy link
Collaborator

@danielpgross danielpgross commented Dec 16, 2024

A few more tweaks to dist generation to precisely match the old behaviour.

  • Ensure all files end with newlines
  • Use an older version of the json gem to match whitespace behaviour for empty arrays
  • Ensure we're using bundler gem versions in bin/product_taxonomy

Copy link
Collaborator Author

danielpgross commented Dec 16, 2024

@danielpgross danielpgross changed the title Match old dist generation whitespace Match old dist whitespace generation Dec 16, 2024
@danielpgross danielpgross marked this pull request as ready for review December 16, 2024 19:43
Copy link
Collaborator

elsom25 commented Dec 16, 2024

Use an older version of the json gem to match whitespace behaviour for empty arrays

🥲

But can be changed post switchover

@danielpgross
Copy link
Collaborator Author

Use an older version of the json gem to match whitespace behaviour for empty arrays

🥲

But can be changed post switchover

Haha agreed, the JSON library change produces a huge diff and I didn't want that to make the real changes here difficult to see. I can create a separate PR that bumps the json version and updates dist/ in one go.

Copy link
Collaborator Author

danielpgross commented Dec 16, 2024

Merge activity

  • Dec 16, 3:17 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 16, 3:20 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 16, 3:32 PM EST: A user merged this pull request with Graphite.

@danielpgross danielpgross force-pushed the 12-16-match_old_dist_generation_whitespace branch from 60fa5f4 to 35b8584 Compare December 16, 2024 20:20
@danielpgross danielpgross merged commit f000935 into main Dec 16, 2024
5 checks passed
@danielpgross danielpgross deleted the 12-16-match_old_dist_generation_whitespace branch December 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants