Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traditional Chinese Language Price check name is not match #343

Open
KanicC opened this issue Dec 19, 2024 · 4 comments
Open

Traditional Chinese Language Price check name is not match #343

KanicC opened this issue Dec 19, 2024 · 4 comments

Comments

@KanicC
Copy link

KanicC commented Dec 19, 2024

The search name is wrong if I use Traditional Chinese for my game language

@leMicin
Copy link
Contributor

leMicin commented Dec 19, 2024

The chinese API contains slightly different information (different order). It makes it tricky to match 1-to-1 to english. I suggest only searching by item class until we find a solution.

@KanicC
Copy link
Author

KanicC commented Dec 19, 2024

There are some people working on tanslating the english trade website to Chinese+ English version
Here is the code, hope it can help
https://greasyfork.org/zh-CN/scripts/520190-poe2-trade-%E7%B9%81%E4%BD%93/code

@leMicin
Copy link
Contributor

leMicin commented Dec 19, 2024

Oh, if we can somehow extract a translated metadata.json from there, we would start getting much better results. Nice find

@KanicC
Copy link
Author

KanicC commented Dec 19, 2024

poe2-trade-zh-main.zip
Also , one more here
This is the completely traditional chinese tranlate google extension for the trading website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants