Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVX2 support #17

Open
OpenSourceAnarchist opened this issue Dec 27, 2023 · 1 comment
Open

Add AVX2 support #17

OpenSourceAnarchist opened this issue Dec 27, 2023 · 1 comment

Comments

@OpenSourceAnarchist
Copy link

I'm not sure if this is as simple as I'm thinking, but over at https://sourceforge.net/projects/mpv-player-windows/files/, that version has a separate "-v3" binary which is compiled at the gnu x86_64_v3 standard, which is mostly limited to Haswell and newer processors. There's AVX2-only code that doesn't get used if support at compile-time isn't enabled.

I really don't use visual studio or WAP or anything msix usually, but from my understanding, the "Release" binary doesn't enable AVX2 by default. Moreover, the Windows Store would have to install the correct version, AVX2 or non-AVX2.

I figured when this was updated to 0.37, you might just take a look at this. It might be as easy as enabling it under Project Property Pages | Configuration Properties | C/C++ | Code Generation | Enable Enhanced Instruction Set or simply including /arch:AVX2. Thanks for considering it!!

@SilverEzhik
Copy link
Owner

Hmm. I'm actually not sure if the Microsoft Store offers a way to ship both of the binaries. Would love to be wrong here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants