Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed warnings noted by CodeChecker; fixes issue #41 #42

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fixed warnings noted by CodeChecker; fixes issue #41 #42

merged 2 commits into from
Feb 5, 2025

Conversation

SimonCahill
Copy link
Owner

@SimonCahill SimonCahill commented Feb 3, 2025 •
edited
Loading

Fixes #41.

CodeChecker result:

Found no defects in isotp.c

----======== Summary ========----
---------------------------------------------
Number of processed analyzer result files | 3
Number of analyzer reports                | 0
---------------------------------------------
----=================----

@SimonCahill
Copy link
Owner Author

@driftregion Just to double-check, could you run CodeChecker on your end?

@SimonCahill
Copy link
Owner Author

No further comments; assuming fixed.

@SimonCahill SimonCahill merged commit eba260d into master Feb 5, 2025
2 checks passed
@SimonCahill SimonCahill deleted the fix/codechecker-warnings branch February 5, 2025 14:19
@driftregion
Copy link
Contributor

Hi Simon, thanks for the fixes! I confirm most of them are gone.

These two are still showing up:

[MEDIUM] isotp-c/isotp.c:80:28: implicit conversion loses integer precision: 'int' to 'uint8_t' (aka 'unsigned char') [clang-diagnostic-implicit-int-conversion]
    size = link->send_size + 1;
                           ^

[MEDIUM] isotp-c/isotp.c:145:24: implicit conversion loses integer precision: 'int' to 'uint8_t' (aka 'unsigned char') [clang-diagnostic-implicit-int-conversion]
    size = data_length + 1;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

static analysis results
2 participants
@SimonCahill @driftregion