Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 "Time remaining" M117 text too long #55

Open
AlbertMN opened this issue Jun 14, 2023 · 4 comments
Open

🐛 "Time remaining" M117 text too long #55

AlbertMN opened this issue Jun 14, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@AlbertMN
Copy link
Member

AlbertMN commented Jun 14, 2023

Text is too long for the screen.
Serial output;

Send: N815 M117 [SP] Time Remaining: 0:00:13*76
Recv: ok
Send: N816 G1 X155.326 Y157.860 E1.4764*86
Recv: ok
Send: N817 M117 [SP] Time Remaining: 0:00:11*76
Recv: ok
Send: N818 G92 E0*70
Recv:  T:210.00 /210.00 B:49.98 /50.00 @:87 B@:22
Recv: X:155.33 Y:157.86 Z:5.00 E:0.00 Count X:12484 Y:12210 Z:2071
Recv: ok
Send: N819 G1 E-5.0000 F1800*20
Recv: ok
Send: N820 M117 [SP] Time Remaining: 0:00:10*73
Recv: ok
Send: N821 G28 X0*80
Recv:  T:210.00 /210.00 B:50.00 /50.00 @:87 B@:19
Recv: echo:busy: processing
Recv:  T:210.00 /210.00 B:50.00 /50.00 @:87 B@:19
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv:  T:210.00 /210.00 B:50.00 /50.00 @:87 B@:20
Recv: echo:busy: processing
Recv:  T:210.00 /210.00 B:49.95 /50.00 @:87 B@:30
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv:  T:210.00 /210.00 B:50.00 /50.00 @:87 B@:20
Recv: echo:busy: processing
Recv:  T:209.88 /210.00 B:50.00 /50.00 @:90 B@:20
Recv: echo:busy: processing
Recv: X:-27.00 Y:157.86 Z:10.72 E:-5.00 Count X:-2160 Y:12629 Z:4178
Recv: ok
Send: N822 M117 [SP] Time Remaining: 0:00:09*67

image

image

@AlbertMN AlbertMN added the bug Something isn't working label Jun 14, 2023
@jneilliii
Copy link
Collaborator

implemented in above commit, can be tested by installing plugin from bugfix/time_remaining branch, or this URL.

https://github.com/SimplyPrint/OctoPrint-SimplyPrint/archive/refs/heads/bugfix/time_remaining.zip

@jneilliii jneilliii assigned AlbertMN and unassigned jneilliii Jun 14, 2023
@WillFJS
Copy link

WillFJS commented Jun 15, 2023

Perhaps have it say 0:00:00 Remaining

@jneilliii
Copy link
Collaborator

We did debate what to use there. went with the shorter left instead of remaining, does remaining make more sense? Seems like it would still be short enough. Can't remember what the character length of a reprap controller is though.

@WillFJS
Copy link

WillFJS commented Jun 15, 2023

I mean I think both work, I asked ChatGPT this is what it said

Both "left" and "remaining" can be used when displaying time, but the choice depends on the context and personal >preference. Here's a breakdown of their usage:

"Time left": This phrase is commonly used when counting down to a specific event or deadline. It implies that time is gradually >decreasing until a certain point. For example, "5 minutes left until the game starts" or "2 days left to submit your assignment." >This phrasing creates a sense of urgency or anticipation.

"Time remaining": This phrase is often used to indicate the duration that still needs to pass until a particular event or deadline. >It emphasizes the total time remaining until completion. For instance, "15 minutes remaining in the class" or "3 hours >remaining until the flight departure." This wording conveys a sense of the time remaining as a whole.

In summary, both "left" and "remaining" are acceptable and commonly used when displaying time. The choice depends on >the desired emphasis and the specific context in which you're communicating.

AlbertMN added a commit that referenced this issue Sep 4, 2023
change printer display time remaining format to `0:00:00 left`, #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants