Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dojo.Deferred not converting #10

Open
mmaxwell opened this issue Apr 1, 2013 · 3 comments
Open

dojo.Deferred not converting #10

mmaxwell opened this issue Apr 1, 2013 · 3 comments
Labels

Comments

@mmaxwell
Copy link
Contributor

mmaxwell commented Apr 1, 2013

dojo.Deferred is not converting to dojo/Deferred.

@francesmcmullin
Copy link
Contributor

Could you elaborate? When I simply did a require and new dojo.Deferred() it converted just fine, are you referring to the conversion from addCallback syntax to then?

@kfranqueiro
Copy link

This is actually another one that might be more of a rabbit hole than it first appears, given that if we wanted to convert fully to dojo/Deferred (which dojo.Deferred isn't), it would cause changes to the underlying API and would break any code using the old dojo/_base/Deferred behavior (such as addCallback). This is another one where I'd sooner err on the side of caution and not convert, rather than risk breaking people's code.

@francesmcmullin
Copy link
Contributor

So you would be in favour of converting dojo.Deferred to dojo/base/Deferred, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants