Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix priority for classinfos in is a ... comparison. #7459

Open
Moderocky opened this issue Jan 16, 2025 · 0 comments
Open

Fix priority for classinfos in is a ... comparison. #7459

Moderocky opened this issue Jan 16, 2025 · 0 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Moderocky
Copy link
Member

Moderocky commented Jan 16, 2025

Some existing (and a lot of upcoming) syntax have an expression that is the same as their type name: a queue, a scoreboard, a team, a task, , etc.

We're trying to eliminate the necessity of new in these patterns (e.g. it's okay to do set {x} to a queue rather than set {x} to a new queue) but the current limitation is that comparison conditions, e.g. if {x} is a queue will always parse as the wrong thing, since the expression is checked before the classinfo.
This means that they parse as if <x> is <a new X expression> rather than if <x> is a <X classinfo>.

Ideally, we want to fix this comparison or at least find a nicer way of resolving the conflict.

I'm leaving this here as a todo and so that we have something to refer to when reviewing the PRs for syntax like this in the future.

@Moderocky Moderocky added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

1 participant